Commit Graph

538 Commits (f35b8ab0b5a2cef36673838d662e249dd9c94686)

Author SHA1 Message Date
gz-c f35b8ab0b5 Restore type information to matched output message 2018-06-09 12:55:18 +01:00
gz-c e4944078a3 Use %v to print matched argument values 2018-06-09 12:55:18 +01:00
Stephan Renatus 38eb60e591 http_assertions: regenerate
Signed-off-by: Stephan Renatus <srenatus@chef.io>
2018-06-09 12:51:17 +01:00
Stephan Renatus adc03609b3 http_assertions: fix docs (missing methods)
Signed-off-by: Stephan Renatus <srenatus@chef.io>
2018-06-09 12:51:17 +01:00
Ernesto Jiménez 26d6fa081f More concrete error in Panics and PanicsWithValue 2018-06-09 12:37:22 +01:00
Harald Nordgren 1c264b1925 Refactor ObjectsAreEqual() 2018-06-09 12:21:57 +01:00
timfeirg 2a15e200fd support diff display for string variables 2018-06-09 11:55:26 +01:00
Nick Pollett ef2d015404 Run generator 2018-06-09 10:23:57 +01:00
Nick Pollett 89226b8388 Compact template 2018-06-09 10:23:57 +01:00
Nick Pollett 6c9d18aaae Optimise template 2018-06-09 10:23:57 +01:00
Cory Bennett c679ae2cc0 add function aliases for common assert and requires function signatures to make table driven tests easier 2018-03-19 22:34:59 +00:00
Shane Ramnode 380174f817 Add placeholder example to docs 2018-03-19 07:43:57 +00:00
Eyal Posener 33951ec724 Add T object and Test method to Mock
This makes is possible to fail the test instead of panicing in case
that the method was called with unexpected arguments.

Fixes #489

mock: change field 'T' to be private field 'test'
mock_test: MockTestingT not using Mock anymore
2018-03-19 07:42:13 +00:00
Eyal Posener 20dae58180 mock_test: remove unecessary code 2018-03-18 18:59:09 +00:00
Eyal Posener 4c1331b42c Anything: remove unecessary type 2018-03-18 18:59:09 +00:00
Dinesh Kumar 921da254ef Displaying mismatch information of arguments diff while panic for closest function call. closes #556 2018-03-18 18:58:37 +00:00
Dinesh Kumar 6efb0c49fb Adding url.Values to request RawQuery, fixes 522 2018-03-18 18:57:06 +00:00
Ernesto Jiménez b89eecf5ca Improve errors from mock assertions
Mark the assert helpers as helpers for Go Versions that support
`t.Helper()`
2018-03-03 14:28:11 +00:00
Jonathan ES Lin 0bfbef4e58 Modify AssertCalled and AssertNotCalled to give better error messages
Co-authored-by: Giuseppe Landolfi <giuseppe.landolfi@ricardo.ch>
Co-authored-by: Ernesto Jiménez <me@ernesto-jimenez.com>
2018-03-03 14:28:11 +00:00
Ben Schumacher bfc76300bb Add note about supported go versions to readme 2018-03-03 11:35:07 +00:00
Ben Schumacher 662d1e61b7 Bump go version to 1.10 2018-03-03 11:35:07 +00:00
Dinesh Kumar be8372ae8e Adding logging when mock assertions fails 2018-02-06 08:25:39 +00:00
Ernesto Jiménez a726187e31 Fix vim-go integration and other editors
Use Go 1.9 t.Helper() to remove testify from the output of the tests and
stop using `\r` to try to overwrite the output.

This means in Go 1.7 and Go 1.8 testify will appear as failing the test.
2018-02-02 18:39:40 +00:00
Ruben de Vries 8824eb48ce Store CallerInfo when On() is called and print for missing calls during AssertExpectations. 2018-02-02 18:36:05 +00:00
Ernesto Jiménez 12b6f73e60 Docs: Remove superfluous parenthesis
As per https://github.com/stretchr/testify/pull/549 from @larsxschneider
2018-01-31 22:38:42 +00:00
Jonathan Jin 85c790041a Correct typo in assert.InDeltaMapValues
s/numbe/number
2018-01-31 22:35:36 +00:00
Ben Schumacher 33e91307d5 Prune vendor & update deps 2018-01-31 22:21:47 +00:00
Ruben de Vries 5f831d47b7 Print missing FAIL during AssertExpectation 2018-01-31 22:19:04 +00:00
Ernesto Jiménez 87b1dfb5b2 Remove returns info from assertion docs
Fixes #525

Return information was propagated to the docs from other wrapper
functions which return nothing.
2017-12-31 13:42:24 +01:00
Ernesto Jiménez bf45a85fc4 Skip vendored packages from tests
Until we drop support of Go < 1.9, skip vendored packages manually.

Once Go 1.11 is released, we would be able to just use ./...
2017-12-31 13:36:49 +01:00
Adam Medzinski 2c9035a78f Changed mock assertions text output to be non-unicode friendly 2017-12-31 12:25:00 +01:00
Ernesto Jiménez 05aa1d4af4 Remove outdated info from README 2017-12-30 20:13:39 +01:00
Ernesto Jiménez b91bfb9ebe Move from Godep to dep for dependency management 2017-12-30 19:17:37 +01:00
Ernesto Jiménez 9ede17e9c0 Drop old Go versions from tests
From now on, we will support the last 3 major Go versions, which covers
at least one year and a half of Go versions.
2017-12-30 19:11:05 +01:00
Ernesto Jiménez 8de2544b9a Fix HTTP assertions to be consistent with the rest
HTTP assertions were missing the trailing `msgAndArgs ...interface{}`,
making it inconsistent with the rest of the assertions and resulting in
incorrect `*f` wrappers.

Fixes #528
2017-12-30 18:45:31 +01:00
Ernesto Jiménez b57b6d191c Add FileExists and DirExists assertions
Implement FileExists and DirExists assertions to check whether file/dir
exist in a given path.

Closes #428
2017-12-30 18:26:00 +01:00
Dinesh Kumar b3596e9279 Fxinng After(time.Duration) to wait properly
commit 5b0291d47dc3a70cc6c6be3bba3c2f934a8e933e
Merge: 1f324ec 8ccf48a
Author: Dinesh Kumar <dineshkumar-cse@users.noreply.github.com>
Date:   Sat Dec 30 19:55:13 2017 +0530

    Merge branch 'master' into master

commit 1f324ec8cbe892a2c5364904643aa1b710121824
Author: Dinesh Kumar <dinesh.kumar@go-jek.com>
Date:   Sat Dec 30 19:07:16 2017 +0530

    Fixing comments: reduced test time, locking in after, unexported waitTime

    - WaitUntil/After overrides each other value
    - currently if channel is set that takes the priority, if not the
      waitTime is used to Sleep

commit a7101ec14224918fc06532acae76418d1b4f04c5
Author: Dinesh Kumar <dinesh.kumar@go-jek.com>
Date:   Fri Dec 29 13:02:14 2017 +0530

    Using if else instead of switch and pulling out the commone one

commit 936f63dd689acacfd051867c5c700489caa1dbc2
Author: Dinesh Kumar <dinesh.kumar@go-jek.com>
Date:   Fri Dec 29 12:41:40 2017 +0530

    After - making it wait during method call

    After was using call.WaitUntil(time.After(duration)),
    <-time.After(duration) returns a channel with the timer immediately
    started
2017-12-30 17:53:34 +01:00
Joel Low cbf22d8d28 Support nil arguments to Argument Matchers 2017-12-30 17:48:55 +01:00
Adam Medzinski 42baa3e5a4 Nil check in Implements assertion 2017-12-30 17:32:04 +01:00
Eyal b3dfaa9086 fail: add test name for logged output
In case of a test failure, the test name will be logged to the output
with makes debugging easier, specially in case of table driven tests.
2017-12-30 17:26:20 +01:00
Maxim Kolganov 6e494f9834 put closestCall.Arguments to the expected side of the diff 2017-12-30 16:53:32 +01:00
Emil Stanchev 51464dae67 Consider empty/nil arrays as matching elements 2017-12-30 16:33:25 +01:00
Emil Stanchev 6f306a68e1 Reuse aLen and bLen variables 2017-12-30 16:33:25 +01:00
Emil Stanchev 76de30ed82 Actually fail tests 2017-12-30 16:33:25 +01:00
Emil Stanchev ae87ba6d08 Ran go generate 2017-12-30 16:33:25 +01:00
Emil Stanchev 8bd27ddf8b Compress some newlines 2017-12-30 16:33:25 +01:00
Emil Stanchev bf57a5dedc ElementsMatch array/slice assertion ignoring order
An assertion that compares the elements of the slices/arrays disregarding the order,
i.e. it checks whether each element in the first slice/array appears the same number of times in it
as in the second slice/array.

This name seemed like it would be easy to find.

Possible alternatives for the name:
- ContainsSameElements
- IsPermutation (C++: http://en.cppreference.com/w/cpp/algorithm/is_permutation)
- MatchArray (rspec: http://www.rubydoc.info/github/rspec/rspec-expectations/RSpec/Matchers:match_array)
- EqualSorted
- Other ideas?

This implementaiton is O(N^2), while sorting both lists first would be O(nlogn).
However, this one doesn't need to copy the lists, so it is simpler and doesn't require additional
memory and time for the copies.

I realize this was deemed as out of scope
https://github.com/stretchr/testify/issues/275
but I decided to give it a shot as I needed it also.
2017-12-30 16:33:25 +01:00
Tim Schaub 0c49dd9bb7 Replace is with in
Minor doc typo.
2017-12-30 16:16:00 +01:00
Emil Stanchev 9fb9de17de Make NotSubset actually fail the test on nil subset
The assertion function was simply returning false, which doesn't actually fail a test.
An example test that should have failed but doesn't:

  func TestNotSubset(t *testing.T) {
      assert.NotSubset(t, []string{"x"}, nil)
  }
2017-12-30 16:07:04 +01:00
Peter Hsu 8ccf48a064 Allow a method call to be optional 2017-12-30 15:23:32 +01:00