GOMODULES
/
testify
mirror of https://github.com/stretchr/testify.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

assert.InEpsilonSlice: refactor 

Remove multiple calls to reflect.Value.Len()
pull/1483/head
Olivier Mengué 2023-10-10 03:37:39 +02:00
parent b5dec80529
commit f728d3c50f
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
assert/assertions.go
View File

@ -1479,11 +1479,12 @@ func InEpsilonSlice(t TestingT, expected, actual interface{}, epsilon float64, m
return Fail(t, "Parameters must be slice", msgAndArgs...)
}
if !IsType(t, expected, actual) || !Len(t, actual, expectedSlice.Len()) {
expectedLen := expectedSlice.Len()
if !IsType(t, expected, actual) || !Len(t, actual, expectedLen) {
return false
}
for i := 0; i < actualSlice.Len(); i++ {
for i := 0; i < expectedLen; i++ {
result := InEpsilon(t, actualSlice.Index(i).Interface(), expectedSlice.Index(i).Interface(), epsilon)
if !result {
return result