From f728d3c50f6131b37d2cfeec52bc33937f1b3aa6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Olivier=20Mengu=C3=A9?= Date: Tue, 10 Oct 2023 03:37:39 +0200 Subject: [PATCH] assert.InEpsilonSlice: refactor Remove multiple calls to reflect.Value.Len() --- assert/assertions.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/assert/assertions.go b/assert/assertions.go index 5f6f742..be6cc26 100644 --- a/assert/assertions.go +++ b/assert/assertions.go @@ -1479,11 +1479,12 @@ func InEpsilonSlice(t TestingT, expected, actual interface{}, epsilon float64, m return Fail(t, "Parameters must be slice", msgAndArgs...) } - if !IsType(t, expected, actual) || !Len(t, actual, expectedSlice.Len()) { + expectedLen := expectedSlice.Len() + if !IsType(t, expected, actual) || !Len(t, actual, expectedLen) { return false } - for i := 0; i < actualSlice.Len(); i++ { + for i := 0; i < expectedLen; i++ { result := InEpsilon(t, actualSlice.Index(i).Interface(), expectedSlice.Index(i).Interface(), epsilon) if !result { return result