GOMODULES
/
pgx
mirror of https://github.com/jackc/pgx.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
3,423 Commits
61 Branches
101 Tags
7.9 MiB
Commit Graph

3423 Commits (f59e8bf5551f403e6b7ec0912097bce85ea21351)

Author SHA1 Message Date
Jack Christensen f59e8bf555 Fix: RowToStructByPos with embedded unexported struct 
https://github.com/jackc/pgx/issues/1583
 2023-04-27 21:03:58 -05:00
Lev Zakharov c27b9b49ea support different bool string representations 2023-04-27 20:29:41 -05:00
Jack Christensen 6defa2a607 Fix error when using BatchResults.Exec 
...on a select that returns an error after some rows.

This was initially found in by a failure with CockroachDB because it
seems to send a RowDescription before an error even when no rows are
returned. PostgreSQL doesn't.
 2023-04-20 21:43:59 -05:00
Jack Christensen a23a423f55 Fix pipelineBatchResults.Exec() not returning error from ResultReader 2023-04-20 21:19:41 -05:00
Jack Christensen 09371981f9 Fix pipeline batch results not closing pipeline 
when error occurs while reading directly from results instead of using
a callback.

https://github.com/jackc/pgx/issues/1578
 2023-04-20 20:58:04 -05:00
Jack Christensen 67f2a41587 Fix scanning a table type into a struct 
Table types have system / hidden columns like tableoid, cmax, xmax, etc.
These are not included when sending or receiving composite types.

https://github.com/jackc/pgx/issues/1576
 2023-04-20 20:13:37 -05:00
Simon Paredes 2cf1541bb9 wrap error 2023-04-11 18:07:05 -05:00
Vinícius Garcia 84eb2e460a Add KSQL on the 3rd party section of the README 2023-04-11 17:53:38 -05:00
Jack Christensen 847f888631 Fix scan array of record to pointer to slice of struct 
https://github.com/jackc/pgx/issues/1570
 2023-04-08 14:39:48 -05:00
Daniel Castro f72a147db3 skip cockroachdb 2023-04-05 17:36:00 -05:00
Daniel Castro 8b7c699b8f proper naming 2023-04-05 17:36:00 -05:00
Daniel Castro 215ffafc74 fix tests 2023-04-05 17:36:00 -05:00
Daniel Castro 5eeaa201d9 add extra tests 2023-04-05 17:36:00 -05:00
Jack Christensen be79f1c8f5 Allow batch callback function to override error 
https://github.com/jackc/pgx/pull/1538#issuecomment-1486083411
 2023-03-31 20:18:05 -05:00
cemre.mengu ca022267db add tests 2023-03-25 10:22:11 -05:00
Cemre Mengu 2a653b4a8d fix: handle null interface for json 
When using `scany` I encountered the following case. This seems to fix it.

Looks like null `jsonb` columns cause the problem. If you create a table like below you can see that the following code fails. Is this expected?

```sql
CREATE TABLE test (
	a int4 NULL,
	b int4 NULL,
	c jsonb NULL
);

INSERT INTO test (a, b, c) VALUES (1, null, null);
```

```go
package main

import (
	"context"
	"log"

	"github.com/georgysavva/scany/v2/pgxscan"
	"github.com/jackc/pgx/v5"
)

func main() {
	var rows []map[string]interface{}
	conn, _ := pgx.Connect(context.Background(), , ts.PGURL().String())
	
	// this will fail with can't scan into dest[0]: cannot scan NULL into *interface {}
	err := pgxscan.Select(context.Background(), conn, &rows, `SELECT c from test`) 
	
	// this works
	// err = pgxscan.Select(context.Background(), conn, &rows, `SELECT a,b from test`)
	
	if err != nil {
		panic(err)
	}

	log.Printf("%+v", rows)
}
```
 2023-03-25 10:22:11 -05:00
Jack Christensen 7af80ae8a6 Batch Query callback is called even when there is an error 
This allows the callback to handle additional error types such as
foreign key constraint violations.

See https://github.com/jackc/pgx/pull/1538.
 2023-03-25 10:21:34 -05:00
Audi P. Risa P 7555c43033 add lax field to namedStructRowScanner 2023-03-25 09:57:38 -05:00
Audi P. Risa P 193bab416f add RowTo(AddrOf)StructByNameLax 2023-03-25 09:57:38 -05:00
Dmitry K e9d64ec29d Use `time.Equal` instead of direct comparison 2023-03-24 17:51:34 -05:00
Dmitry K 2f1bba09c4 Guard deadline readings by mutex 2023-03-24 17:51:34 -05:00
Dmitry K d829073b2f Improve deadline simulation 2023-03-24 17:51:34 -05:00
Dmitry K 48da6435a5 Add deadline simulation 2023-03-24 17:51:34 -05:00
Dmitry K 34e3013153 Remove commented out atomic calls 2023-03-24 17:51:34 -05:00
Dmitry K 009a377028 Use mutex to guard entire `SetBlockingMode` call 2023-03-24 17:51:34 -05:00
Dmitry K e05abb83ec Better error messages 2023-03-24 17:51:34 -05:00
Dmitry K 89475c4c91 use `atomic.Int32` instead of `int + atomic calls` 2023-03-24 17:51:34 -05:00
Dmitry K c3d62c8783 Small comment update 2 2023-03-24 17:51:34 -05:00
Dmitry K 1298a835bc Small comment update 2023-03-24 17:51:34 -05:00
Dmitry K b2b4fbcf57 Set socket to non-blocking mode in `Read`, `Flush` and `BufferReadUntilBlock` operations 2023-03-24 17:51:34 -05:00
Dmitry K 3db7d1774e Set socket to non-blocking mode before `doneChan` is allocated to avoid that channel leaked in case when `SetBlockingMode` will return error 2023-03-24 17:51:34 -05:00
Dmitry K a83faa67f5 Small improvements 2023-03-24 17:51:34 -05:00
Dmitry K 8b5e8d9d89 Fix Windows non-blocking I/O for CopyFrom 
Created based on discussion here: https://github.com/jackc/pgx/pull/1525#pullrequestreview-1344511991

Fixes https://github.com/jackc/pgx/issues/1552
 2023-03-24 17:51:34 -05:00
Sergej Brazdeikis 9ae852eb58 Fix typo in error message `uint32` -> `uint16` 2023-03-11 15:34:08 -06:00
Nicola Murino 19039e6dd1 fix build on 32-bit Windows 2023-03-07 17:09:03 -06:00
Dmitry K 0dbb0a52ab Fix `realNonblockingRead`, set `realNonblockingRead` call error to `nonblockReadErr` 2023-03-04 09:25:36 -06:00
Dmitry K 087b8b2ba8 Try to make windows non-blocking I/O 2023-03-04 09:25:36 -06:00
Jack Christensen c09ddaf440 Add Windows non-blocking IO 2023-03-04 09:25:36 -06:00
Jack Christensen 80eb6e1859 Remove sleeps in test 
Sleeping for a microsecond on Windows actually takes 10ms. This caused
the test to never finish. Instead use channel to ensure the two
goroutines start working at the same time and remove the sleeps.
 2023-02-27 20:32:51 -06:00
Jack Christensen 7ec6ee7b0a Release v5.3.1 2023-02-27 19:57:26 -06:00
Jack Christensen 6105ca5073 Fix TestInternalNonBlockingWriteWithDeadline(t 
The test was relying on sending so big a message that the write blocked.
However, it appears that on Windows the TCP connections over localhost
have an very large or infinite sized buffer. Change the test to simply
set the deadline to the current time before triggering the write.
 2023-02-25 17:02:55 -06:00
Jack Christensen 8f46c75e73 Fix: fake non-blocking read adaptive wait time 
If the time reached the minimum time before the 5 tries were up it
would get stuck reading 1 byte at a time indefinitely.
 2023-02-25 16:45:34 -06:00
Jack Christensen 38e09bda4c Fix *wrapSliceEncodePlan[T].Encode 
It should pass a FlatArray[T] to the next step instead of a
anySliceArrayReflect. By using a anySliceArrayReflect, an encode of
[]github.com/google/uuid.UUID followed by []string into a PostgreSQL
uuid[] would crash. This was caused by a EncodePlan cache collision
where the second encoding used part of the cached plan of the first.

In proper usage a cache collision shouldn't be able to occur. If this
assertion proves incorrect it will be necessary to add an optional
interface to ScanPlan and EncodePlan that marks the plan as ineligable
for caching. But I have been unable to construct a failing case, and
given that ScanPlans have been cached for quite some time now without
incident I do not think it is possible. This issue only occurred due to
the bug in *wrapSliceEncodePlan[T].Encode.

https://github.com/jackc/pgx/issues/1502
 2023-02-21 21:04:30 -06:00
Ch. König 9567297815 add `mgx` module reference to the readme file 2023-02-17 08:58:34 -06:00
Jack Christensen 42d327f660 Add text format jsonpath support 2023-02-14 19:52:47 -06:00
Jack Christensen f17c743c3c Unwatch at end of test 
https://github.com/jackc/pgx/issues/1505
 2023-02-14 09:03:41 -06:00
Jack Christensen a6ace8969b Fix: Prefer sql.Scanner before TryWrapScanPlanFuncs 
This was already the case when the data type was unknown but should also
be the case when it is known.
 2023-02-14 09:03:41 -06:00
Tomáš Procházka c2e278e5d4 simplify duplicate `pgx` registration guard 
The binary search is overkill here.
Readability first.
 2023-02-13 21:08:42 -06:00
Jack Christensen c5daa3a814 Release v5.3.0 2023-02-11 09:15:31 -06:00
Jack Christensen f5d2da7a19 Upgrade golang.org/x/crypto and golang.org/x/text 2023-02-11 08:59:51 -06:00