USEFULL/gogs
1
0
Fork 0
mirror of https://github.com/gogs/gogs.git synced 2025-05-24 00:12:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

lfs: support upload retry (#6061)

Browse Source
This commit is contained in:
ᴜɴᴋɴᴡᴏɴ 2020-04-05 00:45:08 +08:00 committed by GitHub
parent 53b91ef306
commit 4aff4d66ec
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
internal/route/lfs/basic.go
View File

@ -7,6 +7,7 @@ package lfs
import (
"encoding/json"
"io"
"io/ioutil"
"net/http"
"os"
"strconv"
@ -63,7 +64,22 @@ func serveBasicDownload(c *context.Context, repo *db.Repository, oid lfsutil.OID
// PUT /{owner}/{repo}.git/info/lfs/object/basic/{oid}
func serveBasicUpload(c *context.Context, repo *db.Repository, oid lfsutil.OID) {
err := db.LFS.CreateObject(repo.ID, oid, c.Req.Request.Body, lfsutil.StorageLocal)
// NOTE: LFS client will retry upload the same object if there was a partial failure,
// therefore we would like to skip ones that already exist.
_, err := db.LFS.GetObjectByOID(repo.ID, oid)
if err == nil {
// Object exists, drain the request body and we're good.
_, _ = io.Copy(ioutil.Discard, c.Req.Request.Body)
c.Req.Request.Body.Close()
c.Status(http.StatusOK)
return
} else if !db.IsErrLFSObjectNotExist(err) {
internalServerError(c.Resp)
log.Error("Failed to get object [repo_id: %d, oid: %s]: %v", repo.ID, oid, err)
return
}
err = db.LFS.CreateObject(repo.ID, oid, c.Req.Request.Body, lfsutil.StorageLocal)
if err != nil {
internalServerError(c.Resp)
log.Error("Failed to create object [repo_id: %d, oid: %s]: %v", repo.ID, oid, err)