USEFULL
/
gogs
mirror of https://github.com/gogs/gogs.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

models/issue: fix panic when clear labels (#5445)

pull/5544/head
Unknwon 2018-12-02 17:51:24 -05:00
parent e0f18b2255
commit 29c5be47ed
No known key found for this signature in database
GPG Key ID: 25B575AE3213B2B3
3 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gogs.go
View File

@ -16,7 +16,7 @@ import (
"github.com/gogs/gogs/pkg/setting" "github.com/gogs/gogs/pkg/setting"
) )
const APP_VER = "0.11.73.1202" const APP_VER = "0.11.74.1202"
func init() { func init() {
setting.AppVer = APP_VER setting.AppVer = APP_VER

7
models/issue.go
View File

@ -314,8 +314,13 @@ func (issue *Issue) clearLabels(e *xorm.Session) (err error) {
return fmt.Errorf("getLabels: %v", err) return fmt.Errorf("getLabels: %v", err)
} }
// NOTE: issue.removeLabel slices issue.Labels, so we need to create another slice to be unaffected.
labels := make([]*Label, len(issue.Labels))
for i := range issue.Labels { for i := range issue.Labels {
if err = issue.removeLabel(e, issue.Labels[i]); err != nil { labels[i] = issue.Labels[i]
}
for i := range labels {
if err = issue.removeLabel(e, labels[i]); err != nil {
return fmt.Errorf("removeLabel: %v", err) return fmt.Errorf("removeLabel: %v", err)
} }
} }

2
templates/.VERSION
View File

@ -1 +1 @@
0.11.73.1202 0.11.74.1202