mirror of
https://github.com/harness/drone.git
synced 2025-05-05 07:00:23 +00:00
3ba0f75c8d
This change adds the following:
- Space UID + Custom harness validation (accountId for top level space, harness identifier for child spaces)
- Repo UID + Custom harness validation (harness identifier)
- Store Unique casing of space / repo path and add Path.ValueUnique (with Unique index) to allow for application layer controlling the case sensitivity (case insensitive standalone vs partially case sensitive harness)
- Token UID (unique index over ownertype + ownerID + tokenUID)
- Add DisplayName for principals (replaces Name to avoid confustion)
- Store Unique casing of principal UID and add Principal.ValueUnique (with unique index) to allow for application layer, per principal type control of case sensitivity (required in embedded mode)
- Generate serviceAccount UID (+Email) Randomly (sa-{space|repo}-{ID}-{random}) - Allows to have a unique UID across all principals while reducing likelyhood of overlaps with users + avoid overlap across spaces / repos.
- Sync casing of space names (accountId orgId projectId) when creating spaces on the fly (to ensure case sensitivity of - harness code) or use the existing space to update casing.
- Update serviceaccount client to match updated NG Manager API
- in embedded mode create spaces for harness resources owning the service account
48 lines
1.4 KiB
Go
48 lines
1.4 KiB
Go
// Copyright 2022 Harness Inc. All rights reserved.
|
|
// Use of this source code is governed by the Polyform Free Trial License
|
|
// that can be found in the LICENSE.md file for this repository.
|
|
|
|
package serviceaccount
|
|
|
|
import (
|
|
"context"
|
|
|
|
apiauth "github.com/harness/gitness/internal/api/auth"
|
|
"github.com/harness/gitness/internal/api/usererror"
|
|
"github.com/harness/gitness/internal/auth"
|
|
"github.com/harness/gitness/types/enum"
|
|
"github.com/rs/zerolog/log"
|
|
)
|
|
|
|
/*
|
|
* DeleteToken deletes a token of a sevice account.
|
|
*/
|
|
func (c *Controller) DeleteToken(ctx context.Context, session *auth.Session,
|
|
saUID string, tokenUID string) error {
|
|
sa, err := findServiceAccountFromUID(ctx, c.saStore, saUID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// Ensure principal has required permissions on parent (ensures that parent exists)
|
|
if err = apiauth.CheckServiceAccount(ctx, c.authorizer, session, c.spaceStore, c.repoStore,
|
|
sa.ParentType, sa.ParentID, sa.UID, enum.PermissionServiceAccountEdit); err != nil {
|
|
return err
|
|
}
|
|
|
|
token, err := c.tokenStore.FindByUID(ctx, sa.ID, tokenUID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// Ensure sat belongs to service account
|
|
if token.Type != enum.TokenTypeSAT || token.PrincipalID != sa.ID {
|
|
log.Warn().Msg("Principal tried to delete token that doesn't belong to the service account")
|
|
|
|
// throw a not found error - no need for user to know about token?
|
|
return usererror.ErrNotFound
|
|
}
|
|
|
|
return c.tokenStore.Delete(ctx, token.ID)
|
|
}
|