USEFULL
/
drone
mirror of https://github.com/harness/drone.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: [CODE-3341] handle message for multiple codeowners and default reviewers (#3588) 

* fix: [CODE-3341] remove unused string
* fix: [CODE-3341] handle message for multiple codeowners and default reviewers
main
Ritik Kapoor 2025-03-25 10:04:16 +00:00 committed by Harness
parent a86659cb45
commit f4ab120959
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/src/i18n/strings.en.yaml
View File

@ -387,8 +387,8 @@ prReview:
removed: '{author} removed the request for review from {reviewer}'
selfRemoved: '{author} removed their request for review'
filterByReviews: Filter by Reviews
codeowners: '{author} requested review from {codeowners} as code owner'
defaultReviewers: '{author} requested review from {reviewers} as default reviewer'
codeowners: '{author} requested review from {codeowners} as {count|1:code owner,code owners}'
defaultReviewers: '{author} requested review from {reviewers} as {count|1:default reviewer,default reviewers}'
webhookListingContent: 'create,delete,deployment ...'
general: 'General'
webhooks: 'Webhooks'

6
web/src/pages/PullRequest/Conversation/SystemComment.tsx
View File

@ -506,7 +506,8 @@ export const SystemComment: React.FC<SystemCommentProps> = ({ pullReqMetadata, c
str={getString('prReview.codeowners')}
vars={{
author: <strong>{payload?.author?.display_name}</strong>,
codeowners: principalMentions
codeowners: principalMentions,
count: principalNameList.length
}}
/>
</Case>
@ -515,7 +516,8 @@ export const SystemComment: React.FC<SystemCommentProps> = ({ pullReqMetadata, c
str={getString('prReview.defaultReviewers')}
vars={{
author: <strong>{payload?.author?.display_name}</strong>,
reviewers: principalMentions
reviewers: principalMentions,
count: principalNameList.length
}}
/>
</Case>