USEFULL
/
drone
mirror of https://github.com/harness/drone.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

feat: [CDE-192]: ignore deleted spaces during fetching gitspaces for account (#2465) 

* feat: [CDE-192]: ignore deleted spaces during fetching gitspaces for account
pull/3545/head
Ansuman Satapathy 2024-08-11 08:30:37 +00:00 committed by Harness
parent 65b3cabf8f
commit f247c70311
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app/api/controller/gitspace/list_all.go
View File

@ -26,12 +26,13 @@ import (
"github.com/harness/gitness/types/enum"
)
const spaceIsDeleted = "Failed to find space: resource not found"
func (c *Controller) ListAllGitspaces( // nolint:gocognit
ctx context.Context,
session *auth.Session,
) ([]*types.GitspaceConfig, error) {
var result []*types.GitspaceConfig
err := c.tx.WithTx(ctx, func(ctx context.Context) (err error) {
allGitspaceConfigs, err := c.gitspaceConfigStore.ListAll(ctx, session.Principal.UID)
if err != nil {
@ -44,12 +45,14 @@ func (c *Controller) ListAllGitspaces( // nolint:gocognit
if spacesMap[allGitspaceConfigs[idx].SpaceID] == "" {
space, findSpaceErr := c.spaceStore.Find(ctx, allGitspaceConfigs[idx].SpaceID)
if findSpaceErr != nil {
return fmt.Errorf(
"failed to find space for ID %d: %w", allGitspaceConfigs[idx].SpaceID, findSpaceErr)
if findSpaceErr.Error() != spaceIsDeleted {
return fmt.Errorf(
"error fetching space %d: %w", allGitspaceConfigs[idx].SpaceID, findSpaceErr)
}
continue
}
spacesMap[allGitspaceConfigs[idx].SpaceID] = space.Path
}
allGitspaceConfigs[idx].SpacePath = spacesMap[allGitspaceConfigs[idx].SpaceID]
}