USEFULL
/
drone
mirror of https://github.com/harness/drone.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[feat]: [ML-498]: Remved RepoRef from context being sent to LLMs (#3061) 

* Addressed Comments
* Fixed GoLint Issues
* [feat]: [ML-498]: Remved RepoRef from context being sent to LLMs
pull/3597/head
Vivek Dixit 2024-11-28 07:28:38 +00:00 committed by Harness
parent 3c6e41f598
commit ed0e904c59
4 changed files with 8 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/api/controller/aiagent/generate_pipeline_step.go
View File

@ -44,13 +44,7 @@ func (c *Controller) GeneratePipelineStep(
RepoRef: in.RepoRef, RepoRef: in.RepoRef,
} }
// do permission check on repo here? output, err := c.intelligenceService.GenerateStep(ctx, generateRequest)
repo, err := c.repoStore.FindByRef(ctx, in.RepoRef)
if err != nil {
return nil, fmt.Errorf("failed to find repo by ref: %w", err)
}
output, err := c.intelligenceService.GenerateStep(ctx, generateRequest, repo)
if err != nil { if err != nil {
return nil, fmt.Errorf("generate pipeline: %w", err) return nil, fmt.Errorf("generate pipeline: %w", err)
} }

15
app/services/aiagent/aiagent.go
View File

@ -92,23 +92,14 @@ func (s *HarnessIntelligence) Generate(
func (s *HarnessIntelligence) GenerateStep( func (s *HarnessIntelligence) GenerateStep(
ctx context.Context, ctx context.Context,
req *types.PipelineStepGenerateRequest, req *types.PipelineStepGenerateRequest) (*types.PipelineStepGenerateResponse, error) {
repo *types.Repository) (*types.PipelineStepGenerateResponse, error) {
if req.RepoRef == "" {
return nil, fmt.Errorf("no repo ref specified")
}
conversationID := uuid.New() conversationID := uuid.New()
chatRequest := &genai.ChatRequest{ chatRequest := &genai.ChatRequest{
Prompt: req.Prompt, Prompt: req.Prompt,
ConversationID: conversationID.String(), ConversationID: conversationID.String(),
ConversationRaw: "", ConversationRaw: "",
Context: genai.GenerateAIContext( Context: genai.GenerateAIContext(),
genai.RepoRef{ Capabilities: s.cr.Capabilities(),
Ref: repo.Path,
},
),
Capabilities: s.cr.Capabilities(),
} }
resp, err := s.CapabilitiesLoop(ctx, chatRequest) resp, err := s.CapabilitiesLoop(ctx, chatRequest)

9
app/services/capabilities/wire.go
View File

@ -15,9 +15,6 @@
package capabilities package capabilities
import ( import (
"github.com/harness/gitness/app/store"
"github.com/harness/gitness/git"
"github.com/google/wire" "github.com/google/wire"
) )
@ -31,10 +28,10 @@ func panicOnErr(err error) {
} }
} }
func ProvideCapabilities(repoStore store.RepoStore, git git.Interface) (*Registry, error) { func ProvideCapabilities() (*Registry, error) {
registry := NewRegistry() registry := NewRegistry()
panicOnErr(registry.RegisterListFilesCapability(ListFiles(repoStore, git))) // panicOnErr(registry.RegisterListFilesCapability(ListFiles(repoStore, git)))
panicOnErr(registry.RegisterGetFileCapability(GetFile(repoStore, git))) // panicOnErr(registry.RegisterGetFileCapability(GetFile(repoStore, git)))
panicOnErr(registry.RegisterDisplayYamlCapability(DisplayYaml())) panicOnErr(registry.RegisterDisplayYamlCapability(DisplayYaml()))
return registry, nil return registry, nil
} }

2
cmd/gitness/wire_gen.go
View File

@ -422,7 +422,7 @@ func initSystem(ctx context.Context, config *types.Config) (*server.System, erro
migrateWebhook := migrate.ProvideWebhookImporter(webhookConfig, transactor, webhookStore) migrateWebhook := migrate.ProvideWebhookImporter(webhookConfig, transactor, webhookStore)
migrateLabel := migrate.ProvideLabelImporter(transactor, labelStore, labelValueStore, spaceStore) migrateLabel := migrate.ProvideLabelImporter(transactor, labelStore, labelValueStore, spaceStore)
migrateController := migrate2.ProvideController(authorizer, publicaccessService, gitInterface, provider, pullReq, rule, migrateWebhook, migrateLabel, resourceLimiter, auditService, repoIdentifier, transactor, spaceStore, repoStore) migrateController := migrate2.ProvideController(authorizer, publicaccessService, gitInterface, provider, pullReq, rule, migrateWebhook, migrateLabel, resourceLimiter, auditService, repoIdentifier, transactor, spaceStore, repoStore)
registry, err := capabilities.ProvideCapabilities(repoStore, gitInterface) registry, err := capabilities.ProvideCapabilities()
if err != nil { if err != nil {
return nil, err return nil, err
} }