USEFULL/drone
1
0
Fork 0
mirror of https://github.com/harness/drone.git synced 2025-05-31 11:43:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: self as codeowner can be skipped (#1124)

Browse Source
This commit is contained in:
Abhinav Singh 2024-03-20 00:41:02 +00:00 committed by Harness
parent b772dca155
commit dae465a111
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
app/services/codeowners/service.go
View File

@ -320,9 +320,9 @@ func (s *Service) Evaluate(
return &Evaluation{}, nil return &Evaluation{}, nil
} }
evaluationEntries := make([]EvaluationEntry, len(owners.Entries)) evaluationEntries := make([]EvaluationEntry, 0, len(owners.Entries))
for i, entry := range owners.Entries { for _, entry := range owners.Entries {
ownerEvaluations := make([]OwnerEvaluation, 0, len(owners.Entries)) ownerEvaluations := make([]OwnerEvaluation, 0, len(owners.Entries))
userGroupOwnerEvaluations := make([]UserGroupOwnerEvaluation, 0, len(owners.Entries)) userGroupOwnerEvaluations := make([]UserGroupOwnerEvaluation, 0, len(owners.Entries))
for _, owner := range entry.Owners { for _, owner := range entry.Owners {
@ -348,13 +348,18 @@ func (s *Service) Evaluate(
if err != nil { if err != nil {
return nil, fmt.Errorf("error resolving user by email : %w", err) return nil, fmt.Errorf("error resolving user by email : %w", err)
} }
if pr.CreatedBy == userCodeOwner.Owner.ID {
continue
}
ownerEvaluations = append(ownerEvaluations, *userCodeOwner) ownerEvaluations = append(ownerEvaluations, *userCodeOwner)
} }
if len(ownerEvaluations) != 0 || len(userGroupOwnerEvaluations) != 0 {
evaluationEntries[i] = EvaluationEntry{ evaluationEntries = append(evaluationEntries, EvaluationEntry{
Pattern: entry.Pattern, Pattern: entry.Pattern,
OwnerEvaluations: ownerEvaluations, OwnerEvaluations: ownerEvaluations,
UserGroupOwnerEvaluations: userGroupOwnerEvaluations, UserGroupOwnerEvaluations: userGroupOwnerEvaluations,
})
} }
} }