USEFULL/drone
1
0
Fork 0
mirror of https://github.com/harness/drone.git synced 2025-05-31 11:43:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

do not allow creating empty user account

Browse Source
This commit is contained in:
Brad Rydzewski 2019-07-29 13:41:28 -07:00
parent ba82e411a5
commit c78f55cc2f
2 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
CHANGELOG.md
View File

@ -6,12 +6,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## Unreleased ## Unreleased
### Added ### Added
- support for legacy environment variables - support for legacy environment variables
- support for legacy workspace based on repository name - support for legacy workspace based on repository name
- support for github deployment hooks - support for github deployment hooks
- provide base sha for github pull requests - provide base sha for github pull requests
- option to filter webhooks by event and type - option to filter webhooks by event and type
### Fixed
- error when manually creating an empty user, by [@bradrydzewski](https://github.com/bradrydzewski). [#2738](https://github.com/drone/drone/issues/2738).
## [1.2.1] - 2019-06-11 ## [1.2.1] - 2019-06-11
### Added ### Added

12
handler/api/users/create.go
View File

@ -55,9 +55,15 @@ func HandleCreate(users core.UserStore, sender core.WebhookSender) http.HandlerF
if user.Hash == "" { if user.Hash == "" {
user.Hash = uniuri.NewLen(32) user.Hash = uniuri.NewLen(32)
} }
//
// TODO(bradrydzewski) validate the user.Login with a user.Validate() function err = user.Validate()
// if err != nil {
render.ErrorCode(w, err, 400)
logger.FromRequest(r).WithError(err).
Errorln("api: invlid username")
return
}
err = users.Create(r.Context(), user) err = users.Create(r.Context(), user)
if err == core.ErrUserLimit { if err == core.ErrUserLimit {
render.ErrorCode(w, err, 402) render.ErrorCode(w, err, 402)