mirror of https://github.com/harness/drone.git
Use repo edit and repo view permissions for space label handling (#2569)
* Use repo edit and repo view permissions for space label handlingpull/3545/head
parent
b83779350d
commit
af6e94ba2c
|
@ -30,7 +30,7 @@ func (c *Controller) DefineLabel(
|
|||
spaceRef string,
|
||||
in *types.DefineLabelInput,
|
||||
) (*types.Label, error) {
|
||||
space, err := c.getSpaceCheckAuth(ctx, session, spaceRef, enum.PermissionSpaceEdit)
|
||||
space, err := c.getSpaceCheckAuth(ctx, session, spaceRef, enum.PermissionRepoEdit)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("failed to acquire access to space: %w", err)
|
||||
}
|
||||
|
|
|
@ -29,7 +29,7 @@ func (c *Controller) DeleteLabel(
|
|||
spaceRef string,
|
||||
key string,
|
||||
) error {
|
||||
space, err := c.getSpaceCheckAuth(ctx, session, spaceRef, enum.PermissionSpaceEdit)
|
||||
space, err := c.getSpaceCheckAuth(ctx, session, spaceRef, enum.PermissionRepoEdit)
|
||||
if err != nil {
|
||||
return fmt.Errorf("failed to acquire access to space: %w", err)
|
||||
}
|
||||
|
|
|
@ -30,7 +30,7 @@ func (c *Controller) ListLabels(
|
|||
spaceRef string,
|
||||
filter *types.LabelFilter,
|
||||
) ([]*types.Label, int64, error) {
|
||||
space, err := c.getSpaceCheckAuth(ctx, session, spaceRef, enum.PermissionSpaceView)
|
||||
space, err := c.getSpaceCheckAuth(ctx, session, spaceRef, enum.PermissionRepoView)
|
||||
if err != nil {
|
||||
return nil, 0, fmt.Errorf("failed to acquire access to space: %w", err)
|
||||
}
|
||||
|
|
|
@ -30,7 +30,7 @@ func (c *Controller) SaveLabel(
|
|||
spaceRef string,
|
||||
in *types.SaveInput,
|
||||
) (*types.LabelWithValues, error) {
|
||||
space, err := c.getSpaceCheckAuth(ctx, session, spaceRef, enum.PermissionSpaceEdit)
|
||||
space, err := c.getSpaceCheckAuth(ctx, session, spaceRef, enum.PermissionRepoEdit)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("failed to acquire access to space: %w", err)
|
||||
}
|
||||
|
|
|
@ -31,7 +31,7 @@ func (c *Controller) UpdateLabel(
|
|||
key string,
|
||||
in *types.UpdateLabelInput,
|
||||
) (*types.Label, error) {
|
||||
space, err := c.getSpaceCheckAuth(ctx, session, spaceRef, enum.PermissionSpaceEdit)
|
||||
space, err := c.getSpaceCheckAuth(ctx, session, spaceRef, enum.PermissionRepoEdit)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("failed to acquire access to space: %w", err)
|
||||
}
|
||||
|
|
|
@ -32,7 +32,7 @@ func (c *Controller) DefineLabelValue(
|
|||
in *types.DefineValueInput,
|
||||
) (*types.LabelValue, error) {
|
||||
// TODO: permission check should be based on static vs dynamic label
|
||||
space, err := c.getSpaceCheckAuth(ctx, session, spaceRef, enum.PermissionSpaceEdit)
|
||||
space, err := c.getSpaceCheckAuth(ctx, session, spaceRef, enum.PermissionRepoEdit)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("failed to acquire access to space: %w", err)
|
||||
}
|
||||
|
|
|
@ -30,7 +30,7 @@ func (c *Controller) DeleteLabelValue(
|
|||
key string,
|
||||
value string,
|
||||
) error {
|
||||
space, err := c.getSpaceCheckAuth(ctx, session, spaceRef, enum.PermissionSpaceEdit)
|
||||
space, err := c.getSpaceCheckAuth(ctx, session, spaceRef, enum.PermissionRepoEdit)
|
||||
if err != nil {
|
||||
return fmt.Errorf("failed to acquire access to space: %w", err)
|
||||
}
|
||||
|
|
|
@ -31,7 +31,7 @@ func (c *Controller) ListLabelValues(
|
|||
key string,
|
||||
filter *types.ListQueryFilter,
|
||||
) ([]*types.LabelValue, error) {
|
||||
space, err := c.getSpaceCheckAuth(ctx, session, spaceRef, enum.PermissionSpaceView)
|
||||
space, err := c.getSpaceCheckAuth(ctx, session, spaceRef, enum.PermissionRepoView)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("failed to acquire access to space: %w", err)
|
||||
}
|
||||
|
|
|
@ -32,7 +32,7 @@ func (c *Controller) UpdateLabelValue(
|
|||
value string,
|
||||
in *types.UpdateValueInput,
|
||||
) (*types.LabelValue, error) {
|
||||
space, err := c.getSpaceCheckAuth(ctx, session, spaceRef, enum.PermissionSpaceEdit)
|
||||
space, err := c.getSpaceCheckAuth(ctx, session, spaceRef, enum.PermissionRepoEdit)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("failed to acquire access to space: %w", err)
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue