USEFULL
/
drone
mirror of https://github.com/harness/drone.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

log external secret error

pull/2749/head
Brad Rydzewski 2019-06-22 19:00:12 -07:00
parent 6a43a8dbe4
commit 7e23d36e77
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
operator/manager/teardown.go
View File

@ -138,6 +138,9 @@ func (t *teardown) do(ctx context.Context, stage *core.Stage) error {
break
}
}
if build.Started == 0 {
build.Started = build.Finished
}
err = t.Builds.Update(noContext, build)
if err == db.ErrOptimisticLock {

4
plugin/secret/external.go
View File

@ -68,7 +68,7 @@ func (c *externalController) Find(ctx context.Context, in *core.SecretArgs) (*co
client := secret.Client(c.endpoint, c.secret, c.skipVerify)
res, err := client.Find(ctx, req)
if err != nil {
logger.Trace("secret: external: cannot get secret")
logger.WithError(err).Trace("secret: external: cannot get secret")
return nil, err
}
@ -85,7 +85,7 @@ func (c *externalController) Find(ctx context.Context, in *core.SecretArgs) (*co
// empty results.
if (res.Pull == false && res.PullRequest == false) &&
in.Build.Event == core.EventPullRequest {
logger.Trace("secret: external: restricted from forks")
logger.Trace("secret: external: restricted from forks")
return nil, nil
}