mirror of https://github.com/harness/drone.git
feat: [CODE-3289] add support to Verify Committer Identity in security setting (#3575)
* feat: [CODE-3324] remove full stop * feat: [CODE-3324] add support to Verify Committer Identity in security settingmain
parent
9becc91abb
commit
642fa7e2a5
|
@ -1043,6 +1043,8 @@ export interface StringsMap {
|
|||
'securitySettings.scanningSecret': string
|
||||
'securitySettings.scanningSecretDesc': string
|
||||
'securitySettings.updateSuccess': string
|
||||
'securitySettings.verifyCommitterIdentity': string
|
||||
'securitySettings.verifyCommitterIdentityDesc': string
|
||||
'securitySettings.vulnerabilityScanning': string
|
||||
'securitySettings.vulnerabilityScanningDesc': string
|
||||
seeNMoreMatches: string
|
||||
|
|
|
@ -1198,9 +1198,11 @@ importFailed: Import Failed
|
|||
uploadAFileError: There is no image or video uploaded. Please upload an image or video.
|
||||
securitySettings:
|
||||
scanningSecret: Secret Scanning
|
||||
scanningSecretDesc: Block commits containing secrets like passwords, API keys, and tokens.
|
||||
scanningSecretDesc: Block commits containing secrets like passwords, API keys, and tokens
|
||||
vulnerabilityScanning: Vulnerability Scanning
|
||||
vulnerabilityScanningDesc: Scan incoming commits for known vulnerabilities
|
||||
verifyCommitterIdentity: Verify Committer Identity
|
||||
verifyCommitterIdentityDesc: Block commits not committed by the user pushing the changes
|
||||
failedToUpdate: Failed to update security settings
|
||||
updateSuccess: Updated security settings
|
||||
detect: Detect
|
||||
|
|
|
@ -50,6 +50,7 @@ interface FormData {
|
|||
secretScanEnable: boolean
|
||||
vulnerabilityScanEnable: boolean
|
||||
vulnerabilityScanningType: VulnerabilityScanningType
|
||||
verifyCommitterIdentity: boolean
|
||||
}
|
||||
|
||||
const SecurityScanSettings = (props: SecurityScanProps) => {
|
||||
|
@ -89,7 +90,8 @@ const SecurityScanSettings = (props: SecurityScanProps) => {
|
|||
secret_scanning_enabled: !!formData?.secretScanEnable,
|
||||
vulnerability_scanning_mode: formData?.vulnerabilityScanEnable
|
||||
? formData?.vulnerabilityScanningType
|
||||
: VulnerabilityScanningType.DISABLED
|
||||
: VulnerabilityScanningType.DISABLED,
|
||||
principal_committer_match: !!formData?.verifyCommitterIdentity
|
||||
}
|
||||
const response = await updateSecuritySettings(payload)
|
||||
showSuccess(getString('securitySettings.updateSuccess'), 1500)
|
||||
|
@ -100,7 +102,8 @@ const SecurityScanSettings = (props: SecurityScanProps) => {
|
|||
vulnerabilityScanningType:
|
||||
response?.vulnerability_scanning_mode === VulnerabilityScanningType.DISABLED
|
||||
? VulnerabilityScanningType.DETECT
|
||||
: response?.vulnerability_scanning_mode
|
||||
: response?.vulnerability_scanning_mode,
|
||||
verifyCommitterIdentity: !!response?.principal_committer_match
|
||||
}
|
||||
})
|
||||
} catch (exception) {
|
||||
|
@ -121,7 +124,8 @@ const SecurityScanSettings = (props: SecurityScanProps) => {
|
|||
vulnerabilityScanningType:
|
||||
securitySettings?.vulnerability_scanning_mode === VulnerabilityScanningType.DISABLED
|
||||
? VulnerabilityScanningType.DETECT
|
||||
: securitySettings?.vulnerability_scanning_mode
|
||||
: securitySettings?.vulnerability_scanning_mode,
|
||||
verifyCommitterIdentity: securitySettings?.principal_committer_match
|
||||
}}
|
||||
onSubmit={(formData, { resetForm }) => {
|
||||
handleSubmit(formData, resetForm)
|
||||
|
@ -215,6 +219,21 @@ const SecurityScanSettings = (props: SecurityScanProps) => {
|
|||
</Layout.Horizontal>
|
||||
</Container>
|
||||
</Render>
|
||||
<Container padding="medium" margin="medium" className={css.generalContainer}>
|
||||
<Layout.Horizontal
|
||||
spacing={'medium'}
|
||||
padding={{ left: 'medium' }}
|
||||
flex={{ alignItems: 'center', justifyContent: 'flex-start' }}>
|
||||
<FormInput.Toggle
|
||||
{...permissionProps(permPushResult, standalone)}
|
||||
key={'verifyCommitterIdentity'}
|
||||
style={{ margin: '0px' }}
|
||||
label=""
|
||||
name="verifyCommitterIdentity"></FormInput.Toggle>
|
||||
<Text className={css.title}>{getString('securitySettings.verifyCommitterIdentity')}</Text>
|
||||
<Text className={css.text}>{getString('securitySettings.verifyCommitterIdentityDesc')}</Text>
|
||||
</Layout.Horizontal>
|
||||
</Container>
|
||||
</Layout.Vertical>
|
||||
<Layout.Horizontal margin={'medium'} spacing={'medium'}>
|
||||
<Button
|
||||
|
|
Loading…
Reference in New Issue