USEFULL
/
drone
mirror of https://github.com/harness/drone.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: [CODE-2710]: block numeric identifier for root spaces (#2952)

pull/3586/head
Johannes Batzill 2024-11-07 21:59:16 +00:00 committed by Harness
parent ff2da8563e
commit 2f54f4003a
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
types/check/common.go
View File

@ -73,6 +73,8 @@ var (
fmt.Sprintf("The following identifiers are not allowed for a root space: %v", illegalRootSpaceIdentifiers),
}
ErrIllegalRootSpaceIdentifierNumber = &ValidationError{"The identifier of a root space can't be numeric."}
ErrIllegalRepoSpaceIdentifierSuffix = &ValidationError{
fmt.Sprintf("Space and repository identifiers cannot end with %q.", illegalRepoSpaceIdentifierSuffix),
}
@ -177,6 +179,11 @@ func SpaceIdentifierDefault(identifier string, isRoot bool) error {
}
if isRoot {
// root space identifier can't be numeric as it would cause conflicts of space path and space id.
if strings.TrimLeftFunc(identifier, func(r rune) bool { return r >= '0' && r <= '9' }) == "" {
return ErrIllegalRootSpaceIdentifierNumber
}
for _, p := range illegalRootSpaceIdentifiers {
if p == identifierLower {
return ErrIllegalRootSpaceIdentifier