mirror of https://github.com/stretchr/testify.git
118fb83466
## Summary Reduces the confusion assosciated with NotSame that previously would check nothing if any of the values is not a pointer. The changes made were tested using TestSame, TestNotSame, and Test_samePointers tests, and the changes did clear the tests. ## Changes 1. Modified samePointers to return another bool value(ok) that would determine if the 2 values are of pointer type or not, while the returned "same" bool value would determine if the 2 pointers are same. 2. Modified assert.NotSame to call Fail() if the 2 values are either i)pointers pointing to the same address or ii)either/both of the values are not pointers. 3. Modified assert.Same to call Fail() if the 2 values are either i)pointers not pointing to the same address or ii)either/both of the values are not pointers. 4. Modified Test_samePointers to handle the new behavior of samePointers by checking both if the inputs are pointers (ok) and if they point to the same object (same). ## Motivation Ensure NotSame accurately verifies pointer sameness by handling non-pointer inputs explicitly, improving clarity and reducing potential misuse. ## Related issues Closes #1661 --------- Co-authored-by: Bracken <abdawson@gmail.com> |
||
|---|---|---|
| .. | ||
| internal/unsafetests | ||
| yaml | ||
| assertion_compare.go | ||
| assertion_compare_test.go | ||
| assertion_format.go | ||
| assertion_format.go.tmpl | ||
| assertion_forward.go | ||
| assertion_forward.go.tmpl | ||
| assertion_order.go | ||
| assertion_order_test.go | ||
| assertions.go | ||
| assertions_test.go | ||
| doc.go | ||
| errors.go | ||
| forward_assertions.go | ||
| forward_assertions_test.go | ||
| http_assertions.go | ||
| http_assertions_test.go | ||