GOMODULES
/
testify
mirror of https://github.com/stretchr/testify.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
951 Commits
20 Branches
28 Tags
6.5 MiB
Commit Graph

417 Commits (f8f5e6bd3810d7d3e95f3c68956a54ef43398a92)

Author SHA1 Message Date
Olivier Mengué 5ca0755b51 codegen: use standard header for generated files 
Use the standard header in generated Go sources.
See https://go.dev/s/generatedcode.
 2023-07-02 21:06:15 +02:00
Ed 9f0f17fe64 Correct spelling/grammar 2023-05-26 10:38:59 +01:00
Harald Nordgren 4c93d8f201
EqualExportedValues: Handle nested pointer, slice and map fields (#1379) 
* EqualExportedValues: Handle pointer and slice fields

* Update assert/assertions.go

Co-authored-by: Michael Pu <michael.pu123@gmail.com>

* Reduce redundant calls to 'copyExportedFields'

* Update comments

* Add support for maps

* Update Go version support to 1.19 and onward

* Re-generate after rebasing

---------

Co-authored-by: Michael Pu <michael.pu123@gmail.com>
 2023-05-11 07:42:04 +10:00
Tobias Krischer 4b2f4d2bcf
add EventuallyWithT assertion (#1264) 
* add EventuallyWithT assertion

* Change "EventuallyWithT" condition acceptance to no-errors raised

This change updates the "EventuallyWithT" assertion variants (regular, formatted,
requirement) to consider a condition as "met" if no assertion errors were raised
in a tick.

This allows to write easier conditions which simply contain assertions, without
needing to return a bool. The equivalent of a condition returning true in the
previous implementation would be a a condition with a single "assert.True(..)" call.

* Declare the "Collect.Copy(T)" method as a testing helper

* run go generate

---------

Co-authored-by: Arik Kfir <arik@kfirs.com>
 2023-05-10 06:58:49 +10:00
wwade 437071b948
assert: fix error message formatting for NotContains (#1362) 
* assert: rename and refactor TestContainsFailMessage

I've renamed it to TestContainsNotContains and added a test case
structure so that I can use this test to validate the failure messages
from both Contains and NotContains,

There are no functional changes here, strictly refactoring. A new test
case will be added in a subsequent change.

* assert: fix error message formatting for NotContains

It was using "%s" to format the s and contains arguments, but these
could be any type that supports iteration such as a map. In this case
of NotContains failing against a map, it would print something like:

   "map[one:%!s(int=1)]" should not contain "one"

Fix this using "%#v" as was already done for Contains and added test
cases covering both the "len()" / iterable failure messages as well as
the Contains/NotContains failure case.

The new message for this example map would be something like:

    map[string]int{"one":1} should not contain "one"
 2023-05-05 14:05:51 +10:00
Michael Pu c5fc9d6b6b
Compare public elements of struct (#1309) 
* Implement checking only exported fields

Co-authored-by: Anthony Chang <anthony-chang@users.noreply.github.com>

* Update comment

* Run go generate

* Make compatiable with Go 1.16.5

* Fix go generate files

* Fix white space changes

* Fix whitespace changes

* Fix whitespace changes in gogenerate files

---------

Co-authored-by: Anthony Chang <anthony-chang@users.noreply.github.com>
 2023-03-14 22:01:35 +10:00
Daniel White f36bfe3c33
Fix Subset/NotSubset when map is missing keys from the subset (#1261) 
`MapIndex` returns a zero `reflect.Value` if the map value does not
exist. This now aligns more closely with `InDeltaMapValues` by
checking `reflect/Value.IsValid`.

The use of `recover()` was hiding this error by setting the result of
the test to be "false" despite the test suite passing. This led to
flapping tests where they would succeed if the panic occurred on a
missing key before comparing key values that didn't match!

I've ensured the test suite now asserts on the expected error message
and added another example where the subset has keys not found on the
map under test.
 2023-02-25 22:46:30 +10:00
Bogdan Drutu f7b49d3ed7
Add support to compare uintptr 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
 2023-02-04 16:27:21 -08:00
Artem V. Navrotskiy 0ab3ce1249
Fix `CallerInfo()` source file paths (#1288) 2023-01-03 20:57:11 +10:00
Milan Lesichkov c029f419b8
Fix adding ? when no values passed 2022-12-22 10:45:24 +00:00
sunpeng 9acc22213e
fix: fix bug for check unsafe.Pointer isNil (#1319) 2022-12-20 19:39:16 +10:00
Stavros Ntentos 181cea6eab
impr: `CallerInfo` should print full paths to the terminal (#1201) 
* impr: `CallerInfo` should print full paths to the terminal

I am proposing this simple change, which changes this output
```
--- FAIL: TestABC (0.00s)
    --- FAIL: TestABC/C (0.00s)
        /this/is/a/path/to/file_test.go:258:
            	Error Trace:	file_test.go:258
            	            				file_test.go:748
            	Error:      	Not equal:
...
```
to this:
```
--- FAIL: TestABC (0.00s)
    --- FAIL: TestABC/C (0.00s)
        /this/is/a/path/to/file_test.go:258:
            	Error Trace:	/this/is/a/path/to/file_test.go:258
            	            				/this/is/a/path/to/file_test.go:748
            	Error:      	Not equal:
...
```

With the latter output, it is much more straightforward to find the file
you are looking for, even though in the displayed case, the file is the same.

However, for VSCodium, the case is a little more helpful, since VSCodium's
terminal is smart enough to recognize the output, and make links out of that input.

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>

* test: fix the tests that depended on the previous behavior

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>

Co-authored-by: Stavros Ntentos <11300730-stavros-relex@users.noreply.gitlab.com>
 2022-06-29 20:56:06 +10:00
Oladapo Ajala 66eef0ef3a
fix: assert.MapSubset (or just support maps in assert.Subset) (#1178) 
* WIP: added map key value check in subset

* upgraded subset & notsubset to check handle maps
 2022-06-28 21:24:53 +10:00
Ruan Moolman 2fab6dffcf
Add WithinTimeRange method (#1188) 
* Add WithinTimeRange method

* Run ./.ci.generate.sh

* Rename WithinTimeRange to WithinRange

* Rename WithinRange expected parameter to actual

* Capitalise start parameter at start of error message

* Improve WithinRange example
 2022-06-28 21:14:39 +10:00
Ryan Leung c31ea0312f
Support comparing byte slice (#1202) 
* support comparing byte slice

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* address the comment

Signed-off-by: Ryan Leung <rleungx@gmail.com>
 2022-06-21 14:54:58 +10:00
Adam Luzsi 840cb80149
arrays value types in a zero-initialized state are considered empty (#1126) 
* fix .Empty assertion with Array types

* refactor .Empty assertion for array types
 2022-06-20 20:44:27 +10:00
cuishuang 35864782d2 assert: fix typo 
Signed-off-by: cuishuang <imcusg@gmail.com>
 2022-05-04 20:29:57 +10:00
RmbRT 083ff1c044 Fixed didPanic to now detect panic(nil). 
Previously, the function would not detect panic(nil) calls.
In didPanic, removed the anonymous function call, instead,
added named return values. Added extra test cases for the
panic(nil) call.
 2022-03-16 07:08:43 +10:00
Torkel Rogstad 1e36bfe104 Use cross Go version compatible build tag syntax 2022-02-15 20:26:04 +10:00
Torkel Rogstad e798dc2763 Add docs on 1.17 build tags 2022-02-15 20:26:04 +10:00
Torkel Rogstad 83198c2c50 assert: guard CanConvert call in backward compatible wrapper 2022-02-15 20:26:04 +10:00
Torkel Rogstad 087b655c75 assert: allow comparing time.Time 2022-02-15 20:26:04 +10:00
Ilia Kravets 7bcf74e94f fix msgAndArgs forwarding 2022-02-10 20:09:05 +10:00
Ilia Kravets c29de71342 add tests for correct msgAndArgs forwarding 
len(msgAndArgs)>1 should lead to fmt.Sprintf()
 2022-02-10 20:09:05 +10:00
Menno ab6dc32628 fix linting errors in /assert package 2021-08-24 21:55:23 +10:00
Menno edff5a049b fix funtion name 2021-08-24 21:55:23 +10:00
Menno 5c61ef97ae fix potential nil-pointer dereference 
the fix gracefully fails the assertion instead of panicking unresolved.
 2021-08-24 21:55:23 +10:00
Menno fd9e1fb0e1 Fix NaN similarity checks 
Plus minor alignments in code.
 2021-07-09 20:35:46 +10:00
Harald Nordgren dc5c261377 Make sure time.Time comparison produces a helpful diff. closes #989 2021-04-27 21:16:43 +10:00
Alun Evans 6990a05d54 Add ErrorContains 2021-01-16 12:32:05 +11:00
Yongxin Wang bf646ea5b3 add test to check that Helper is called 2021-01-15 21:06:28 +11:00
Yongxin Wang 6f81fdf1db fix the output source file in test output 2021-01-15 21:06:28 +11:00
Graham Jenson c26b7f39f8 Update assertions.go 
lower to 10
 2020-11-03 21:38:56 +11:00
Graham Jenson 8fb4b2442e [Fix] The most recent changes to golang/protobuf breaks the spew Circular data structure detection 
The latest update to golang/protobuf (I am on v1.4.2) break the spew circular data structure detection. This means that when calling `assert.Equal(t, proto1, proto2)` will not only fail, but also enter an infinite recursion.

Given spew is not being actively maintained, and tesitfy should set some upper bound, we need to set a `MaxDepth` to some very high number, so at least the test will not run for a very long time and finish and fail quickly.
 2020-11-03 21:38:56 +11:00
Masaya Hayashi dc8af7208c add generated code for positive/negative assertion 2020-11-03 21:37:46 +11:00
Masaya Hayashi 1544508911 add assert positive/negative 2020-11-03 21:37:46 +11:00
alexpantyukhin cf221cc875 add tests and fix message 2020-08-14 20:45:51 +10:00
alexpantyukhin c74c0d3a7f add fnctions into requres 2020-08-14 20:45:51 +10:00
alexpantyukhin a9284e66a9 add assertion order 2020-08-14 20:45:51 +10:00
Martijn a3bed97cf3 assert: s/rune/r/ to avoid "rune" predeclared ident shadowing #642 
Thanks @quasllyte
 2020-08-03 19:54:30 +10:00
Boyan ed4976c764 Revert "Fix PR comments" 
This reverts commit 1ebd9c5791.
 2020-07-27 22:28:46 +10:00
arseny 415d89281b Fix time.Time not equals bug 
Adding test
 2020-07-27 21:16:21 +10:00
arseny 1ebd9c5791 Fix PR comments 2020-07-27 21:16:21 +10:00
Pal Sivertsen 95a9d909e9 Add wrapper functions for errors Is and As funcs 
This commit adds wrapper functions for Is and As functions from the
errors package.
 2020-07-20 20:40:44 +10:00
Torkel Rogstad 51595dcf94 Allow comparing custom comparable types 
Prior to this commit, this would not work:

```go
type myInt int
assert.Less(t, myInt(1), myInt(2)) // panic!
```

We add some type conversions, similarly to how `ObjectsAreEqualValues`
work. This allows us to compare `myInt` to `myInt`, as well as `myInt`
to `int`.
 2020-06-22 19:40:53 +10:00
Ivo van der Wijk b8f7d52a4a Rewrite test loops into individual test cases 2020-06-13 21:33:52 +10:00
Ivo van der Wijk 8a501b0fac make testcase definition local 2020-06-13 21:33:52 +10:00
Ivo van der Wijk 4bbffeac6c table-ify TestElementsMatch 2020-06-13 21:33:52 +10:00
Ivo van der Wijk 52b38ca424 table-ify, refactor (Not)Subset() 2020-06-13 21:33:52 +10:00
Ivo van der Wijk 0929293466 refactor, table-ify TestContains / TestNotContains 2020-06-13 21:33:52 +10:00
Ivo van der Wijk 67a4d91853 table-ify ObjectsAreEqual() 2020-06-13 21:33:52 +10:00
Ivo van der Wijk 5717c498e9 table-ify Equal() 2020-06-13 21:33:52 +10:00
Ivo van der Wijk 408bc6703a keep type definition local to function where used 2020-06-13 21:33:52 +10:00
Ivo van der Wijk 590942c47f table-ify Exactly 2020-06-13 21:33:52 +10:00
Ivo van der Wijk 9ffb85bbec clarify sets of tests 2020-06-13 21:33:52 +10:00
Ivo van der Wijk 51b7cfe385 rewrite NotEqual() tests to table tests 2020-06-13 21:33:52 +10:00
Ivo van der Wijk 07d1e00890 first attempt at table-ifying NotEqualValues tests 2020-06-13 21:33:52 +10:00
Ivo van der Wijk f50e178a9f first attempt at table-ifying NotEqualValues tests 2020-06-13 21:33:52 +10:00
Boyan 3184a9e141 This reverts commit 0a813b5898. 2020-06-05 20:47:15 +10:00
Boyan 6353e56395 This reverts commit 9d083cac4a. 2020-06-05 20:47:15 +10:00
Boyan 656132404a This reverts commit 484fff1ace. 2020-06-05 20:47:15 +10:00
Boyan 46420cf544 This reverts commit 1a43b8334a. 2020-06-05 20:47:15 +10:00
Boyan 303198d014 Revert "allow body for HTTPBodyContains and HTTPBodyNotContains for 
POST" PR #938

This reverts commit 136026fb25.
 2020-06-05 20:47:15 +10:00
Ivo van der Wijk 004e3cb722 commit generated files 2020-05-27 08:39:56 +10:00
Ivo van der Wijk ac1463f956 Implement NotEqualValues 2020-05-27 08:39:56 +10:00
Matt Gorzka e72b029e2a new regex 2020-05-14 20:01:26 +10:00
zjx158094 d4e7ca1687 address comments 2020-05-14 19:53:33 +10:00
zjx158094 8329c5daa7 add test 2020-05-14 19:53:33 +10:00
zjx20 3ec00f620a assertion_compare: fix format string for numbers 2020-05-14 19:53:33 +10:00
Pedro de Brito 15aff29f35 docs: update Comparison function comment 2020-05-06 18:14:40 +10:00
Bryan Boreham f7ef284eb4 Add a benchmark to time trivial call of NotNil 2020-05-04 21:01:24 +10:00
Bryan Boreham e734bda58c Avoid calling Helper() on the happy path. 
Helper() in the standard Go runtime fetches a stack trace from the
runtime, so is slow for calls that are made many times.

Helper() only makes a difference if the call throws an error, so move
it after the test in straightforward cases.
 2020-05-04 21:01:24 +10:00
gohargasparyan 136026fb25 add test cases 2020-05-04 07:47:34 +10:00
gohargasparyan 1a43b8334a add test cases 2020-05-04 07:47:34 +10:00
gohargasparyan 484fff1ace didn't notice should run go generate 2020-05-04 07:47:34 +10:00
gohargasparyan 9d083cac4a go format 2020-05-04 07:47:34 +10:00
gohargasparyan 0a813b5898 allow body for HTTPBodyContains and HTTPBodyNotContains for POST 2020-05-04 07:47:34 +10:00
David Wragg ca8e08c131 Support uint in InDelta and InEpsilon 
InDelta and InEpsilon assertions on uint values would fail with
the error "Parameters must be numerical".
 2020-04-29 21:29:26 +10:00
Dave Henderson d3decad621 Update dependency to gopkg.in/yaml.v3 
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
 2020-04-28 07:45:39 +10:00
Martijn bb468cc94d Remove unneeded return statements 2020-04-06 07:42:56 +10:00
Martijn 28b7455875 Ran go generate ./... 2020-04-06 07:42:56 +10:00
Martijn e0afeb10e3 Fix whitespace issues 2020-04-06 07:42:56 +10:00
Martijn 1454493cee Add test for HTTPStatusCode 
For purposes of the test, status code 101 is checked as this does not overlap with the other assertions. (HTTPSuccess, HTTPRedirect and HTTPError)
 2020-04-06 07:42:56 +10:00
Martijn f0828adbb3 Add HTTPStatusCode assertion 
Allows for asserting a specific HTTP status code was returned instead of a general success, error or redirect assertion.
 2020-04-06 07:42:56 +10:00
hectorj 012967472b Make InEpsilon fail when given a NaN 
fixes #918
 2020-04-02 22:34:25 +11:00
Martin Sucha f6cbfc0d03 Print more details in ElementsMatch 
It is not very helpful to print that the lengths differ when an
assertion fails, since that does not reveal what the cause of the issue
might be.

Let's print which elements are extra in each list, that should convey
the relevant information to the user. Also use spew to format the
objects, similar to what Equal does, to make the output more readable.
 2020-03-14 21:17:20 +11:00
Henry Blyth cb23521296 Test verbose Contains Fail message 
If asserting an error contained in a string, includeElement will fail
but Contains will confusingly print both values as strings, which can
look like a testify problem instead of an assertion failure.
 2020-03-10 08:59:40 +11:00
Jordan Christiansen c12dcedf28 Include the type in assert.Contains error messages 
Fixes #828
 2020-03-10 08:59:40 +11:00
alexpantyukhin 6be346c1f1 rename order files to compare files 2020-03-09 08:00:09 +11:00
Alexander Pantyukhin 9388656beb fix language 2020-03-06 19:44:08 +11:00
Alexander Pantyukhin 2ca25e3fac fix for assertions 2020-03-06 19:44:08 +11:00
Alexander Pantyukhin ec73f449b3 add new tests 2020-03-06 19:44:08 +11:00
Alexander Pantyukhin 0b4ff03cda update assertion_order.go according review notes 2020-03-06 19:44:08 +11:00
Alexander Pantyukhin ad53dbbf0a put constants instead of values. 2020-03-06 19:44:08 +11:00
alexpantyukhin d583a38000 fix with gofmt tool 2020-03-06 19:44:08 +11:00
alexpantyukhin f4b48264a4 fix fmt 2020-03-06 19:44:08 +11:00
alexpantyukhin c106be4ce3 refactoring of assertion_order 2020-03-06 19:44:08 +11:00
Christian Muehlhaeuser 02b2656991 Handle ineffectual assignments 
Removed ineffectual assignments.
 2020-03-06 16:18:13 +11:00
Christian Muehlhaeuser 1c7f4ef084 Avoid unnecessary conversions 
No need to convert values here.
 2020-03-06 14:40:56 +11:00
Christian Muehlhaeuser 08b5acc756 Fixed tautological errors 
err can't ever be not nil here, unless the Go language specs are changing.
 2020-03-06 14:38:03 +11:00