672 Commits

Author SHA1 Message Date
Ernesto Jiménez
c7668ea997 Fixes #339 - Add assertionf assertions like Errorf and Equalf 2017-05-29 12:56:43 +01:00
Ernesto Jiménez
c33f336b92 Fix vet warnings and go generate to update docs 2017-05-29 12:56:43 +01:00
Ben Blount
3104bf5483 Use Go 1.7 subtests so suites can properly nest
This removes dependencies on Go Testing Internals and
also enables test methods within a suite to have subtests.

Fixes #346
2017-05-29 12:27:49 +01:00
Ernesto Jiménez
b8c9b4ef3d Merge pull request #447 from stretchr/issue-442
Fix race condition on mock package's Called
2017-05-28 14:51:04 +01:00
Ernesto Jiménez
bd79c01e74 Fix race condition on mock package's Called
Closes #442
2017-05-28 14:43:48 +01:00
Ernesto Jiménez
253219d8d4 Merge pull request #396 from medzin/issue-379
HTTP code status assertions now fail tests
2017-05-28 13:28:02 +01:00
Ernesto Jiménez
edd8e19ece Run go generate to syn generated assertions 2017-05-28 12:30:45 +01:00
Ernesto Jiménez
aa10ab5551 Merge pull request #382 from GlenDC/feat-test-subset
add Subset and NotSubset assertions
2017-05-28 12:29:49 +01:00
Adam Medziński
78be756ee7 Fixed HTTP assertions messages formatting and removed wrong test message 2017-05-28 13:23:04 +02:00
decauwsemaecker.glen@gmail.com
3a59a58abc
add Subset and NotSubset assertions 2017-05-27 17:24:18 -05:00
Ernesto Jiménez
e68c5c5208 Merge pull request #446 from stretchr/gofmt-in-travis
Check code is formatted in travis
2017-05-27 20:19:13 +01:00
Ernesto Jiménez
dd57c7b68a Check code is formatted in travis 2017-05-27 19:12:18 +01:00
Ernesto Jiménez
eb84487cae Merge pull request #441 from stretchr/revert-commits
Revert PRs with
2017-05-26 07:56:33 +01:00
Ernesto Jiménez
f712be9266 Revert "add mock.MethodCalled(methodName, args...)"
This reverts commit 17a0bd50e9ddb9f2dbff569e5c01a27e9171be96.

Should avoid simply exporting an internal method.
2017-05-26 07:47:23 +01:00
Ernesto Jiménez
34687ebd28 Revert "diffArguments: remove unnecessary range-for (#417)"
This reverts commit 5c861cc4a41d0c534deebc34de0fa1ffd15429bf.

Bug was already fixed in another merge.
2017-05-26 07:46:34 +01:00
Ernesto Jiménez
2b76a9702e Revert "Added goconvey style assertions to the mock package"
This reverts commit faf0710ff28e0389cd8f4761de3fbf4b7cd1057d.
2017-05-26 07:46:02 +01:00
Terin Stock
b6296e3859 fix(docs): correct Error usage examples
Correct the usage of `assert.Equal` in the Error and NoError usage
examples, which had reversed the expected and actual arguments.
2017-05-25 17:42:54 -07:00
Tedde Lundgren
d2f3716b44 Add msgAndArgs pass forward to InDelta from InDeltaSlice 2017-05-25 17:40:33 -07:00
Peter Ebden
158f9d0389 Check that there is a directory before trying to access it. 2017-05-25 17:40:15 -07:00
Richard Knop
18cfa6871f Added extra unit test for function with mixed variadic arguments. 2017-05-25 17:38:37 -07:00
Simon Mulser
b1f1bcb83a fix typo 2017-05-25 17:32:03 -07:00
Cameron Moore
09f61d78b8 assert: fix error reporting when error contains escape sequences
Fixes #325
2017-05-25 17:28:59 -07:00
Joseph Anthony Pasquale Holsten
5c861cc4a4 diffArguments: remove unnecessary range-for (#417)
When `len(actual) > len(expected)`, this for loop would cause a panic.

Alternative to this implementation, there could be a check for
`if len(actual) != len(expected)`, but generating a meaningful message
describing that is already provided by `diff()`. So we defer to diff in
every case.

Fixes #393
2017-05-25 17:27:00 -07:00
havnesvo
bc11a6e4dd Tighten language by increasing overall consistency in wording in texts and argument names: use 'actual' instead of 'received' 2017-05-25 17:16:55 -07:00
Jonas Finnemann Jensen
115ab90138 Provide argument name args in function signature
This mainly serves to make code-completion better in IDEs that automatically create the function signature.
2017-05-25 17:13:31 -07:00
Andy McCall
faf0710ff2 Added goconvey style assertions to the mock package 2017-05-25 17:05:23 -07:00
Denys Smirnov
97c0e43cd5 compare bytes with bytes.Equal instead of reflect.DeepEqual 2017-05-25 17:04:05 -07:00
Yimin Chen
17a0bd50e9 add mock.MethodCalled(methodName, args...) 2017-05-25 17:03:17 -07:00
Tagir Magomedov
9afdd65e6a Check number of provided arguments vs mocked
Pre-diff:
```
panic: runtime error: index out of range
```

Post-diff:
```
panic:

mock: Unexpected Method Call
-----------------------------

MyFunction(string,string,string)
		0: string,
		1: string,
		2: string

The closest call I have is:

MyFunction(string,string)
		0: "mock.Anything"
		1: "mock.Anything"

Provided 3 arguments, mocked for 2 arguments
```
2017-05-25 17:02:05 -07:00
Davide D'Agostino
c67caccbce Merge pull request #438 from josephholsten/test-old-go
travis: rm broken go releases
2017-05-25 16:56:26 -07:00
Joseph Anthony Pasquale Holsten
287336f43d travis: rm broken go releases
Some dependencies no longer support go <= 1.3.

github.com/davecgh/go-spew/spew and github.com/stretchr/objx depend on
the "bytes" package, and github.com/pmezard/go-difflib/difflib depends
on the "bufio" package.

This change removes them from tested platforms in travis. It may make
sense to explicitly doc the lack of support elsewhere.
2017-05-09 10:24:37 -07:00
Joseph Anthony Pasquale Holsten
32d79c51da travis: check if these platforms are broken 2017-05-09 09:55:59 -07:00
Adam Medziński
5c9da494dd HTTP code status assertions now fail tests 2017-02-10 14:36:52 +01:00
Ernesto Jiménez
4d4bfba8f1 Merge pull request #392 from stretchr/add-nil-unequal-check
Add Equal test comparing nil with non-nil
2017-01-30 12:31:45 +01:00
Ernesto Jiménez
332ae0e18f Add Equal test comparing nil with non-nil 2017-01-30 11:25:29 +00:00
Ernesto Jiménez
2402e8e7a0 Merge pull request #364 from nmiyake/fixFailOutput
Ensure that assert.Fail properly align its output
2016-12-17 14:04:45 -06:00
Ernesto Jiménez
598ab58e60 Merge pull request #171 from ANPez/master
Release lock before .WaitUntil
2016-12-17 13:32:40 -06:00
Ernesto Jiménez
cd206b0fb2 Merge pull request #318 from esdrasbeleza/master
Add callbacks to be run after and before each test
2016-12-17 13:30:15 -06:00
Ernesto Jiménez
ae4c58e530 Merge pull request #367 from packrat386/rm_numeric_check
Remove isNumericType check
2016-12-17 13:26:48 -06:00
Ernesto Jiménez
6ac14537c7 Merge pull request #370 from nmiyake/fixTypos
Fix typos in comments in _codegen/main.go
2016-12-17 13:17:21 -06:00
Ernesto Jiménez
211175bc28 Merge pull request #377 from seppestas/typo-fixes
Fixed minor typo
2016-12-17 13:16:51 -06:00
Ernesto Jiménez
59b4bc5db1 Merge pull request #371 from nmiyake/addEqualityDocs
Add comments for Equal and NotEqual to clarify pointer comparison
2016-12-17 13:16:33 -06:00
Seppe Stas
434d5c1f51 Fixed minor typo
"interface", was missing the 'r'
2016-12-02 13:02:34 +01:00
Nick Miyake
3928f579ee Add comments for Equal and NotEqual to clarify pointer comparison
Clarify that pointer equality is determined by equality of values
rather than memory address.

Fixes #358
2016-11-19 23:31:18 -08:00
Nick Miyake
13b9dd4e30 Fix typos in comments in _codegen/main.go 2016-11-19 22:28:54 -08:00
Aidan Coyle
6835870125 Remove isNumericType check
I'm not sure why this check is needed. It seems worthwhile to print the
type any time the types aren't equal. Closes #366.
2016-11-17 10:29:04 -06:00
Ernesto Jiménez
18a02ba4a3 Merge pull request #365 from atombender/remove_addresses_from_diff
When diffing with spew, use a format that doesn't include pointer addresses
2016-11-16 23:43:51 -08:00
Alexander Staubo
cbd71e7dd4 When diffing with spew, use a format that doesn't include pointer addresses (which
generate false negatives). This updates go-spew to 04cdfd42973bb9c8589fd6a731800cf222fde1a9.
2016-10-29 16:24:47 -04:00
Nick Miyake
ddb91ee140 Ensure that assert.Fail properly align its output
Previous implementation depended on tab alignment. This worked
when the output was not prepended with anything, but would break
if the output was prepended with further spaces (which can occur
in environments like IntelliJ test runners). This commit fixes it
so that the output is always aligned logically.

Fixes #83
2016-10-28 19:36:52 -07:00
Esdras Beleza
5e72f93a89 Remove timestamp from callback 2016-09-26 13:48:19 -03:00