Samuel Nelson
02a8ab057b
Reverse ConvertibleTo check to avoid panic
...
in `ObjectsAreEqual`, `expectedValue.Convert(actualType)` was being called when
`actualType.ConvertibleTo(reflect.TypeOf(expected))` was true. This was a problem
for situations such as when expected was an int and actual was a string, since
ints are `ConvertibleTo` strings, but the reverse is not true.
Changing the ConvertibleTo check to `expectedValue.Type().ConvertibleTo(actualType)`
solves the issue.
2015-01-10 12:18:57 -07:00
Tyler
2eaa4b48b8
Merge pull request #110 from cryptix/master
...
added tests from PR #103
2014-12-22 10:16:26 -07:00
Tyler Bunnell
d1472b75d1
fix merge conflict
2014-12-22 10:15:32 -07:00
Henry
7a9121a162
added tests from PR #103
2014-12-17 16:41:45 +01:00
Raphael Meyer
43f1d3eeb3
replace imports in travis config to not break to origin
2014-11-30 09:53:17 +01:00
Raphael Meyer
d8aebdb1b6
replaces imports to run with my travis config
2014-11-30 09:39:28 +01:00
Raphael Meyer
807610fbf1
Use deep equal after conversion.
2014-11-30 09:22:56 +01:00
Raphael Meyer
88bce07c05
Convert actual to expected type. Fix unit tests
2014-11-29 18:51:34 +01:00
Raphael Meyer
794aba658c
Use valueOf to fix issue with []byte
2014-11-29 18:23:40 +01:00
Neil Conway
38aecdc957
Fix panic when comparing unequal maps.
...
The change in #94 resulted in using == to compare two values that might not be
comparable. Hence, this resulted in a panic for situations like:
ObjectsAreEqual(map[int]int{5: 10}, map[int]int{10: 20})
The fix is to use reflect.DeepEqual() instead.
2014-11-24 16:11:51 -08:00
Mat Ryer
faedd6eb63
Merge pull request #94 from neilconway/object-equality-golang-1.4
...
Avoid relying on undefined behavior in assert.ObjectsAreEqual().
2014-11-24 12:06:32 -08:00
Victor Kryukov
d3556349dd
Fix #99 : Contains doesn't work for complex types
2014-11-18 15:26:31 -08:00
Neil Conway
49c5c6cdb1
Avoid relying on undefined behavior in assert.ObjectsAreEqual().
...
The previous assert.ObjectsAreEqual() implementation is broken in go 1.4beta1:
x := uint64(3)
log.Printf("equal? %t", assert.ObjectsAreEqual(3, x))
This prints "true" under Go 1.3 and "false" under 1.4beta1 (amd64/darwin).
The reason is that the ObjectsAreEqual() was comparing two reflect.Value values
for equality using ==, but the behavior of that operation is apparently
undefined (https://code.google.com/p/go/issues/detail?id=9034 ). The fix is to do
the type conversion and then do the comparison between two interface{} values.
2014-10-31 16:02:32 -07:00
Tyler
de7fcff264
Merge pull request #87 from victorkryukov/http-patch
...
Implement HTTP(Success|Error|Redirect) and HTTPBody(Not)Contains
2014-09-14 20:00:11 -06:00
Victor Kryukov
8b09ac0ee8
Implement HTTP(Success|Error|Redirect) and HTTPBody(Not)Contains
2014-09-14 11:54:12 -06:00
Victor Kryukov
b64f0d0b59
Implement Regexp and NotRegexp
2014-09-13 13:13:42 -06:00
Tyler
15dabc1a45
Merge pull request #73 from comogo/includes
...
Allow Contains and NotContains to check slices and arrays
2014-09-09 20:31:58 -06:00
Tyler
b8d551e7d1
Merge pull request #76 from victorkryukov/master
...
Increase testify/assert test coverage from 86.6% to 97.1%, fix bugs.
2014-09-09 08:10:22 -06:00
Josiah Kiehl (formerly @bluepojo)
27b1e9d9f2
Fix grammer on assert.Len()
...
🐹
2014-09-04 15:55:45 -07:00
Victor
0f9ba46361
Minor doc string update
2014-08-28 13:05:46 -07:00
Victor Kryukov
5461242ffd
Increase assert test coverage from 86.6% to 97.1%, fixed bugs.
...
Extend tests for NotEqual, Len and add tests for Condition, InEpsilon.
Add tests for Assertion.Condition, Assertion.InEpsilon, Assertion.InDelta
Fix a bug for Assertion.InDelta, Assertion.InEpsilon having incorrect signature.
2014-08-28 12:56:51 -07:00
Mateus Lorandi dos Santos
ab1fdba54e
Allow Contains and NotContains to check slices and arrays
2014-08-21 11:13:02 -03:00
Oliver Beattie
3c808d3dab
Print the expected and actual items of an Equal call on separate lines
...
Makes for much easier comparison visually
2014-08-17 17:57:22 +01:00
Tyler
ae3032ce42
Merge pull request #69 from ascheglov/feature-fatal_checks
...
Add fatal assertions
2014-07-28 14:04:10 -06:00
OMOTO Kenji
e787d6aa9d
Add Len()
2014-07-17 18:39:50 +09:00
Anatoly Scheglov
f6376e8a31
add the 'require' package
2014-07-16 17:30:01 +04:00
bhenderson
0241e55b78
Add to forward_assertions and fix docs.
2014-07-10 09:31:54 -07:00
bhenderson
d0803a1a3a
Revert "Add InDelta() and InEpsilon() to docs and remove doc duplication."
...
This reverts commit d8398675f9
.
2014-07-10 09:27:48 -07:00
bhenderson
d8398675f9
Add InDelta() and InEpsilon() to docs and remove doc duplication.
2014-07-10 09:26:13 -07:00
bhenderson
256f07baef
Refactor InEpsilon() to use InDelta().
2014-07-10 09:12:30 -07:00
bhenderson
60a27ebea6
Add InEpsilon().
2014-07-10 08:58:49 -07:00
bhenderson
3b602c6e81
Add InDelta() for comparing floats.
2014-07-10 08:49:17 -07:00
2pi
7d4050544d
add `EqualError` to doc.go
...
* Add both the standard `EqualError` and the wrapped `EqualError`
2014-07-01 14:55:26 +02:00
2pi
8515a19013
add wrapper around the `EqualError` function
...
* add a `*Assertions` wrapper around the `EqualError` function
* add tests
2014-07-01 13:29:33 +02:00
Tyler Bunnell
459056d303
Merge forward assertions.
2014-06-30 11:34:00 -06:00
Tyler Bunnell
5cc789b89e
Clean up golint warnings
2014-06-18 09:28:16 -06:00
Tyler Bunnell
37ec10ac14
Make empty tests pass
...
Fix #58
2014-06-18 09:21:09 -06:00
Tyler Bunnell
d951608d14
Add test for empty ints
2014-06-18 09:20:40 -06:00
James Bowes
21382c1202
Attempt type conversion in assert.Equal
...
If the two values being tested are of compatible types, convert one
value to the other's type before comparing them. This allows
`assert.Equal(int64(123), uint64(123))` to pass.
2014-06-03 19:01:48 -03:00
Mat Ryer
8eaef7fd24
Merge pull request #49 from seantalts/noerrormsg
...
Change NoError formatting. fixes #48
2014-04-25 08:23:39 -06:00
Tyler Bunnell
d3d427864d
Fix merge conflict
2014-04-22 10:01:40 -06:00
mreedell
2c7459d4ba
Fixing issue 33
2014-04-14 15:24:44 -04:00
Sean Talts
c469b75615
Change NoError formatting.
2014-04-04 11:36:55 -04:00
Guncha
5114cbfc4a
Fix #45 : assert.Empty should work with channels
2014-03-31 19:10:48 -04:00
SATO taichi
7675c8d8af
add more examples to README and doc.go.
2014-03-11 17:52:22 +09:00
taichi
e8eaa8ab7a
add better API.
...
because current API is redundant because the pass every time testingT.
2014-03-11 16:38:25 +09:00
Mat Ryer
24fb97e3a8
Merge pull request #39 from xsleonard/exacterror
...
ExactError, asserts that err is not nil and its string matches
2014-03-07 11:27:35 -07:00
Victor Blomqvist
12fea7c16c
Rename the error argument from theError to err in Error asserts.
2014-03-07 17:19:03 +08:00
Steve Leonard
e763434382
rename to EqualError
2014-02-15 15:06:23 -05:00
Steve Leonard
92af479c56
ExactError, asserts that err is not nil and its string matches
2014-02-15 12:24:39 -05:00