From e7b6c143052f6ca99c13a2eb07aebc3250cbe9bf Mon Sep 17 00:00:00 2001 From: Dinesh Kumar Date: Fri, 2 Aug 2019 18:00:16 +0530 Subject: [PATCH] Remove parallel as that makes goroutines deadlock --- suite/suite_order_test.go | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/suite/suite_order_test.go b/suite/suite_order_test.go index d9c217b..91a56f6 100644 --- a/suite/suite_order_test.go +++ b/suite/suite_order_test.go @@ -1,8 +1,10 @@ package suite import ( + "math/rand" "strings" "testing" + "time" "github.com/stretchr/testify/assert" ) @@ -13,9 +15,7 @@ type CallOrderSuite struct { } func (s *CallOrderSuite) call(method string) { - // s.Mutex.Lock() - // defer s.Mutex.Unlock() - + time.Sleep(time.Duration(rand.Intn(300)) * time.Millisecond) s.callOrder = append(s.callOrder, method) } @@ -28,10 +28,9 @@ func (s *CallOrderSuite) SetupSuite() { func (s *CallOrderSuite) TearDownSuite() { s.call("TearDownSuite") - assert.Equal(s.T(), "SetupSuite;SetupTest;Test A;TearDownTest;TearDownSuite", strings.Join(s.callOrder, ";")) + assert.Equal(s.T(), "SetupSuite;SetupTest;Test A;TearDownTest;SetupTest;Test B;TearDownTest;TearDownSuite", strings.Join(s.callOrder, ";")) } func (s *CallOrderSuite) SetupTest() { - s.T().Parallel() s.call("SetupTest") } @@ -43,7 +42,6 @@ func (s *CallOrderSuite) Test_A() { s.call("Test A") } -//func (s *CallOrderSuite) Test_B() { -// time.Sleep(time.Second) -// s.call("Test B") -//} +func (s *CallOrderSuite) Test_B() { + s.call("Test B") +}