Review: Drop doc line and fix typo

Review feedback:
https://github.com/stretchr/testify/pull/1129#discussion_r1786495803
This commit is contained in:
Pål Sivertsen 2024-10-04 09:52:45 +02:00
parent aade8450b3
commit dc100b1be3
5 changed files with 8 additions and 16 deletions

View File

@ -621,8 +621,7 @@ func NotEqualValuesf(t TestingT, expected interface{}, actual interface{}, msg s
return NotEqualValues(t, expected, actual, append([]interface{}{msg}, args...)...) return NotEqualValues(t, expected, actual, append([]interface{}{msg}, args...)...)
} }
// NotErrorAsf asserts that at none of the errors in err's chain matches target. // NotErrorAsf asserts that none of the errors in err's chain matches target.
// This is the inverse of the ErrorAs function.
func NotErrorAsf(t TestingT, err error, target interface{}, msg string, args ...interface{}) bool { func NotErrorAsf(t TestingT, err error, target interface{}, msg string, args ...interface{}) bool {
if h, ok := t.(tHelper); ok { if h, ok := t.(tHelper); ok {
h.Helper() h.Helper()

View File

@ -1234,8 +1234,7 @@ func (a *Assertions) NotEqualf(expected interface{}, actual interface{}, msg str
return NotEqualf(a.t, expected, actual, msg, args...) return NotEqualf(a.t, expected, actual, msg, args...)
} }
// NotErrorAs asserts that at none of the errors in err's chain matches target. // NotErrorAs asserts that none of the errors in err's chain matches target.
// This is the inverse of the ErrorAs function.
func (a *Assertions) NotErrorAs(err error, target interface{}, msgAndArgs ...interface{}) bool { func (a *Assertions) NotErrorAs(err error, target interface{}, msgAndArgs ...interface{}) bool {
if h, ok := a.t.(tHelper); ok { if h, ok := a.t.(tHelper); ok {
h.Helper() h.Helper()
@ -1243,8 +1242,7 @@ func (a *Assertions) NotErrorAs(err error, target interface{}, msgAndArgs ...int
return NotErrorAs(a.t, err, target, msgAndArgs...) return NotErrorAs(a.t, err, target, msgAndArgs...)
} }
// NotErrorAsf asserts that at none of the errors in err's chain matches target. // NotErrorAsf asserts that none of the errors in err's chain matches target.
// This is the inverse of the ErrorAs function.
func (a *Assertions) NotErrorAsf(err error, target interface{}, msg string, args ...interface{}) bool { func (a *Assertions) NotErrorAsf(err error, target interface{}, msg string, args ...interface{}) bool {
if h, ok := a.t.(tHelper); ok { if h, ok := a.t.(tHelper); ok {
h.Helper() h.Helper()

View File

@ -2149,8 +2149,7 @@ func ErrorAs(t TestingT, err error, target interface{}, msgAndArgs ...interface{
), msgAndArgs...) ), msgAndArgs...)
} }
// NotErrorAs asserts that at none of the errors in err's chain matches target. // NotErrorAs asserts that none of the errors in err's chain matches target.
// This is the inverse of the ErrorAs function.
func NotErrorAs(t TestingT, err error, target interface{}, msgAndArgs ...interface{}) bool { func NotErrorAs(t TestingT, err error, target interface{}, msgAndArgs ...interface{}) bool {
if h, ok := t.(tHelper); ok { if h, ok := t.(tHelper); ok {
h.Helper() h.Helper()

View File

@ -1559,8 +1559,7 @@ func NotEqualf(t TestingT, expected interface{}, actual interface{}, msg string,
t.FailNow() t.FailNow()
} }
// NotErrorAs asserts that at none of the errors in err's chain matches target. // NotErrorAs asserts that none of the errors in err's chain matches target.
// This is the inverse of the ErrorAs function.
func NotErrorAs(t TestingT, err error, target interface{}, msgAndArgs ...interface{}) { func NotErrorAs(t TestingT, err error, target interface{}, msgAndArgs ...interface{}) {
if h, ok := t.(tHelper); ok { if h, ok := t.(tHelper); ok {
h.Helper() h.Helper()
@ -1571,8 +1570,7 @@ func NotErrorAs(t TestingT, err error, target interface{}, msgAndArgs ...interfa
t.FailNow() t.FailNow()
} }
// NotErrorAsf asserts that at none of the errors in err's chain matches target. // NotErrorAsf asserts that none of the errors in err's chain matches target.
// This is the inverse of the ErrorAs function.
func NotErrorAsf(t TestingT, err error, target interface{}, msg string, args ...interface{}) { func NotErrorAsf(t TestingT, err error, target interface{}, msg string, args ...interface{}) {
if h, ok := t.(tHelper); ok { if h, ok := t.(tHelper); ok {
h.Helper() h.Helper()

View File

@ -1235,8 +1235,7 @@ func (a *Assertions) NotEqualf(expected interface{}, actual interface{}, msg str
NotEqualf(a.t, expected, actual, msg, args...) NotEqualf(a.t, expected, actual, msg, args...)
} }
// NotErrorAs asserts that at none of the errors in err's chain matches target. // NotErrorAs asserts that none of the errors in err's chain matches target.
// This is the inverse of the ErrorAs function.
func (a *Assertions) NotErrorAs(err error, target interface{}, msgAndArgs ...interface{}) { func (a *Assertions) NotErrorAs(err error, target interface{}, msgAndArgs ...interface{}) {
if h, ok := a.t.(tHelper); ok { if h, ok := a.t.(tHelper); ok {
h.Helper() h.Helper()
@ -1244,8 +1243,7 @@ func (a *Assertions) NotErrorAs(err error, target interface{}, msgAndArgs ...int
NotErrorAs(a.t, err, target, msgAndArgs...) NotErrorAs(a.t, err, target, msgAndArgs...)
} }
// NotErrorAsf asserts that at none of the errors in err's chain matches target. // NotErrorAsf asserts that none of the errors in err's chain matches target.
// This is the inverse of the ErrorAs function.
func (a *Assertions) NotErrorAsf(err error, target interface{}, msg string, args ...interface{}) { func (a *Assertions) NotErrorAsf(err error, target interface{}, msg string, args ...interface{}) {
if h, ok := a.t.(tHelper); ok { if h, ok := a.t.(tHelper); ok {
h.Helper() h.Helper()