review feedback

assert/assertions.go

@@ -221,13 +221,14 @@ func CallerInfo() []string {
 	callers := []string{}
 	pcs := make([]uintptr, stackFrameBufferSize)
 	offset := 1
+
+	for {
 		n := runtime.Callers(offset, pcs)
 
 		if n == 0 {
-		return []string{}
+			break
 		}
 
-	maybeMore := n == stackFrameBufferSize
 		frames := runtime.CallersFrames(pcs[:n])
 
 		for {
@@ -273,23 +274,12 @@ func CallerInfo() []string {
 				isTest(name, "Example") {
 				break
 			}
-
-		if more {
-			continue
+			if !more {
+				break
+			}
 		}
 		// We know we already have less than a buffer's worth of frames
-		if !maybeMore {
-			break
-		}
 		offset += stackFrameBufferSize
-		n = runtime.Callers(offset, pcs)
-		if n == 0 {
-			break
-		}
-
-		maybeMore = n == stackFrameBufferSize
-
-		frames = runtime.CallersFrames(pcs[:n])
 
 	}