Merge pull request #1502 from stretchr/suite-fix-reporting-of-panic-location

suite: fix recoverAndFailOnPanic to report test failure at the right location
pull/1405/merge
Sean Marciniak 2024-02-01 08:44:43 +10:30 committed by GitHub
commit c3b0c9b4f5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 0 deletions

View File

@ -78,11 +78,13 @@ func (suite *Suite) Assert() *assert.Assertions {
}
func recoverAndFailOnPanic(t *testing.T) {
t.Helper()
r := recover()
failOnPanic(t, r)
}
func failOnPanic(t *testing.T, r interface{}) {
t.Helper()
if r != nil {
t.Errorf("test panicked: %v\n%s", r, debug.Stack())
t.FailNow()
@ -165,6 +167,8 @@ func Run(t *testing.T, suite TestingSuite) {
suite.SetT(t)
defer recoverAndFailOnPanic(t)
defer func() {
t.Helper()
r := recover()
if stats != nil {