From ab3b9743a738c228e875cb71b3c285698a908885 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Olivier=20Mengu=C3=A9?= Date: Tue, 10 Oct 2023 03:32:57 +0200 Subject: [PATCH] assert.InEpsilonSlice: refactor --- assert/assertions.go | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/assert/assertions.go b/assert/assertions.go index 1e55fbf..44a1625 100644 --- a/assert/assertions.go +++ b/assert/assertions.go @@ -1466,14 +1466,18 @@ func InEpsilonSlice(t TestingT, expected, actual interface{}, epsilon float64, m if h, ok := t.(tHelper); ok { h.Helper() } - if expected == nil || actual == nil || - reflect.TypeOf(actual).Kind() != reflect.Slice || - reflect.TypeOf(expected).Kind() != reflect.Slice { + + if expected == nil || actual == nil { return Fail(t, "Parameters must be slice", msgAndArgs...) } - actualSlice := reflect.ValueOf(actual) expectedSlice := reflect.ValueOf(expected) + actualSlice := reflect.ValueOf(actual) + + if expectedSlice.Type().Kind() != reflect.Slice || + actualSlice.Type().Kind() != reflect.Slice { + return Fail(t, "Parameters must be slice", msgAndArgs...) + } for i := 0; i < actualSlice.Len(); i++ { result := InEpsilon(t, actualSlice.Index(i).Interface(), expectedSlice.Index(i).Interface(), epsilon)