review feedback

pull/1614/head
Mike Auclair 2024-06-25 11:50:49 +00:00
parent 176474a4c9
commit 7f10816c93
1 changed files with 17 additions and 15 deletions

View File

@ -222,11 +222,12 @@ func CallerInfo() []string {
pcs := make([]uintptr, stackFrameBufferSize) pcs := make([]uintptr, stackFrameBufferSize)
offset := 1 offset := 1
n := runtime.Callers(offset, pcs) n := runtime.Callers(offset, pcs)
maybeMore := n == stackFrameBufferSize
if n == 0 { if n == 0 {
return []string{} return []string{}
} }
maybeMore := n == stackFrameBufferSize
frames := runtime.CallersFrames(pcs[:n]) frames := runtime.CallersFrames(pcs[:n])
for { for {
@ -273,7 +274,9 @@ func CallerInfo() []string {
break break
} }
if !more { if more {
continue
}
// We know we already have less than a buffer's worth of frames // We know we already have less than a buffer's worth of frames
if !maybeMore { if !maybeMore {
break break
@ -287,7 +290,6 @@ func CallerInfo() []string {
maybeMore = n == stackFrameBufferSize maybeMore = n == stackFrameBufferSize
frames = runtime.CallersFrames(pcs[:n]) frames = runtime.CallersFrames(pcs[:n])
}
} }