GOMODULES
/
testify
mirror of https://github.com/stretchr/testify.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed HTTP assertions messages formatting and removed wrong test message

pull/396/head
Adam Medziński 2017-05-28 13:21:34 +02:00 committed by Adam Medziński
parent 5c9da494dd
commit 78be756ee7
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
assert/http_assertions.go
View File

@ -34,7 +34,7 @@ func HTTPSuccess(t TestingT, handler http.HandlerFunc, method, url string, value
isSuccessCode := code >= http.StatusOK && code <= http.StatusPartialContent isSuccessCode := code >= http.StatusOK && code <= http.StatusPartialContent
if !isSuccessCode { if !isSuccessCode {
Fail(t, fmt.Sprintf("Expected HTTP success status code for \"%s\" but received \"%d\"", url+"?"+values.Encode(), code)) Fail(t, fmt.Sprintf("Expected HTTP success status code for %q but received %d", url+"?"+values.Encode(), code))
} }
return isSuccessCode return isSuccessCode
@ -54,7 +54,7 @@ func HTTPRedirect(t TestingT, handler http.HandlerFunc, method, url string, valu
isRedirectCode := code >= http.StatusMultipleChoices && code <= http.StatusTemporaryRedirect isRedirectCode := code >= http.StatusMultipleChoices && code <= http.StatusTemporaryRedirect
if !isRedirectCode { if !isRedirectCode {
Fail(t, fmt.Sprintf("Expected HTTP redirect status code for \"%s\" but received \"%d\"", url+"?"+values.Encode(), code)) Fail(t, fmt.Sprintf("Expected HTTP redirect status code for %q but received %d", url+"?"+values.Encode(), code))
} }
return isRedirectCode return isRedirectCode
@ -74,7 +74,7 @@ func HTTPError(t TestingT, handler http.HandlerFunc, method, url string, values
isErrorCode := code >= http.StatusBadRequest isErrorCode := code >= http.StatusBadRequest
if !isErrorCode { if !isErrorCode {
Fail(t, fmt.Sprintf("Expected HTTP error status code for \"%s\" but received \"%d\"", url+"?"+values.Encode(), code)) Fail(t, fmt.Sprintf("Expected HTTP error status code for %q but received %d", url+"?"+values.Encode(), code))
} }
return isErrorCode return isErrorCode

2
assert/http_assertions_test.go
View File

@ -44,7 +44,7 @@ func TestHTTPRedirect(t *testing.T) {
mockT2 := new(testing.T) mockT2 := new(testing.T)
assert.Equal(HTTPRedirect(mockT2, httpRedirect, "GET", "/", nil), true) assert.Equal(HTTPRedirect(mockT2, httpRedirect, "GET", "/", nil), true)
assert.False(mockT2.Failed(), "WHAT") assert.False(mockT2.Failed())
mockT3 := new(testing.T) mockT3 := new(testing.T)
assert.Equal(HTTPRedirect(mockT3, httpError, "GET", "/", nil), false) assert.Equal(HTTPRedirect(mockT3, httpError, "GET", "/", nil), false)