From 3c60a0e014736771c87897eac552da55838e5747 Mon Sep 17 00:00:00 2001
From: devdinu <dinesh.kumar@gojek.com>
Date: Thu, 16 Jan 2020 08:23:53 +0530
Subject: [PATCH] Merging suite_order_test in suite test, removing anonymous
 defer func call

---
 suite/suite.go            |  4 +---
 suite/suite_order_test.go | 47 ---------------------------------------
 suite/suite_test.go       | 39 ++++++++++++++++++++++++++++++++
 3 files changed, 40 insertions(+), 50 deletions(-)
 delete mode 100644 suite/suite_order_test.go

diff --git a/suite/suite.go b/suite/suite.go
index 75c4658..6195301 100644
--- a/suite/suite.go
+++ b/suite/suite.go
@@ -114,9 +114,7 @@ func Run(t *testing.T, suite TestingSuite) {
 		test := testing.InternalTest{
 			Name: method.Name,
 			F: func(t *testing.T) {
-				defer func() {
-					testsSync.Done()
-				}()
+				defer testsSync.Done()
 				parentT := suite.T()
 				suite.SetT(t)
 				defer failOnPanic(t)
diff --git a/suite/suite_order_test.go b/suite/suite_order_test.go
deleted file mode 100644
index 91a56f6..0000000
--- a/suite/suite_order_test.go
+++ /dev/null
@@ -1,47 +0,0 @@
-package suite
-
-import (
-	"math/rand"
-	"strings"
-	"testing"
-	"time"
-
-	"github.com/stretchr/testify/assert"
-)
-
-type CallOrderSuite struct {
-	Suite
-	callOrder []string
-}
-
-func (s *CallOrderSuite) call(method string) {
-	time.Sleep(time.Duration(rand.Intn(300)) * time.Millisecond)
-	s.callOrder = append(s.callOrder, method)
-}
-
-func TestSuiteCallOrder(t *testing.T) {
-	Run(t, new(CallOrderSuite))
-}
-func (s *CallOrderSuite) SetupSuite() {
-	s.call("SetupSuite")
-}
-
-func (s *CallOrderSuite) TearDownSuite() {
-	s.call("TearDownSuite")
-	assert.Equal(s.T(), "SetupSuite;SetupTest;Test A;TearDownTest;SetupTest;Test B;TearDownTest;TearDownSuite", strings.Join(s.callOrder, ";"))
-}
-func (s *CallOrderSuite) SetupTest() {
-	s.call("SetupTest")
-}
-
-func (s *CallOrderSuite) TearDownTest() {
-	s.call("TearDownTest")
-}
-
-func (s *CallOrderSuite) Test_A() {
-	s.call("Test A")
-}
-
-func (s *CallOrderSuite) Test_B() {
-	s.call("Test B")
-}
diff --git a/suite/suite_test.go b/suite/suite_test.go
index e08467d..5d757dd 100644
--- a/suite/suite_test.go
+++ b/suite/suite_test.go
@@ -3,7 +3,9 @@ package suite
 import (
 	"errors"
 	"io/ioutil"
+	"math/rand"
 	"os"
+	"strings"
 	"testing"
 	"time"
 
@@ -443,3 +445,40 @@ func TestSuiteLogging(t *testing.T) {
 		assert.NotContains(t, output, "TESTLOGPASS")
 	}
 }
+
+type CallOrderSuite struct {
+	Suite
+	callOrder []string
+}
+
+func (s *CallOrderSuite) call(method string) {
+	time.Sleep(time.Duration(rand.Intn(300)) * time.Millisecond)
+	s.callOrder = append(s.callOrder, method)
+}
+
+func TestSuiteCallOrder(t *testing.T) {
+	Run(t, new(CallOrderSuite))
+}
+func (s *CallOrderSuite) SetupSuite() {
+	s.call("SetupSuite")
+}
+
+func (s *CallOrderSuite) TearDownSuite() {
+	s.call("TearDownSuite")
+	assert.Equal(s.T(), "SetupSuite;SetupTest;Test A;TearDownTest;SetupTest;Test B;TearDownTest;TearDownSuite", strings.Join(s.callOrder, ";"))
+}
+func (s *CallOrderSuite) SetupTest() {
+	s.call("SetupTest")
+}
+
+func (s *CallOrderSuite) TearDownTest() {
+	s.call("TearDownTest")
+}
+
+func (s *CallOrderSuite) Test_A() {
+	s.call("Test A")
+}
+
+func (s *CallOrderSuite) Test_B() {
+	s.call("Test B")
+}