mirror of
https://github.com/jackc/pgx.git
synced 2025-05-31 11:42:24 +00:00
af0ca3a39b
Original issue https://github.com/jackc/pgtype/issues/68 This crash occurred in the recursive assignment system used to support multidimensional arrays. This was fixed in 9639a69d451f55456f598c1aa8b93053f8df3088. However, that fix incorrectly used nil instead of an empty slice. In hindsight, it appears the fundamental error is that an assignment to a slice of a type that is not specified is handled with the recursive / reflection path. Or another way of looking at it is as an unexpected feature where []T can now be scanned if individual elements are assignable to T even if []T is not specifically handled. But this new reflection / recursive path did not handle empty arrays. This fix handles the reflection path for an empty slice by allocating an empty slice.
283 lines
9.0 KiB
Go
283 lines
9.0 KiB
Go
package pgtype_test
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
|
|
"github.com/jackc/pgtype"
|
|
"github.com/jackc/pgtype/testutil"
|
|
)
|
|
|
|
func TestVarcharArrayTranscode(t *testing.T) {
|
|
testutil.TestSuccessfulTranscode(t, "varchar[]", []interface{}{
|
|
&pgtype.VarcharArray{
|
|
Elements: nil,
|
|
Dimensions: nil,
|
|
Status: pgtype.Present,
|
|
},
|
|
&pgtype.VarcharArray{
|
|
Elements: []pgtype.Varchar{
|
|
{String: "foo", Status: pgtype.Present},
|
|
{Status: pgtype.Null},
|
|
},
|
|
Dimensions: []pgtype.ArrayDimension{{Length: 2, LowerBound: 1}},
|
|
Status: pgtype.Present,
|
|
},
|
|
&pgtype.VarcharArray{Status: pgtype.Null},
|
|
&pgtype.VarcharArray{
|
|
Elements: []pgtype.Varchar{
|
|
{String: "bar ", Status: pgtype.Present},
|
|
{String: "NuLL", Status: pgtype.Present},
|
|
{String: `wow"quz\`, Status: pgtype.Present},
|
|
{String: "", Status: pgtype.Present},
|
|
{Status: pgtype.Null},
|
|
{String: "null", Status: pgtype.Present},
|
|
},
|
|
Dimensions: []pgtype.ArrayDimension{{Length: 3, LowerBound: 1}, {Length: 2, LowerBound: 1}},
|
|
Status: pgtype.Present,
|
|
},
|
|
&pgtype.VarcharArray{
|
|
Elements: []pgtype.Varchar{
|
|
{String: "bar", Status: pgtype.Present},
|
|
{String: "baz", Status: pgtype.Present},
|
|
{String: "quz", Status: pgtype.Present},
|
|
{String: "foo", Status: pgtype.Present},
|
|
},
|
|
Dimensions: []pgtype.ArrayDimension{
|
|
{Length: 2, LowerBound: 4},
|
|
{Length: 2, LowerBound: 2},
|
|
},
|
|
Status: pgtype.Present,
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestVarcharArraySet(t *testing.T) {
|
|
successfulTests := []struct {
|
|
source interface{}
|
|
result pgtype.VarcharArray
|
|
}{
|
|
{
|
|
source: []string{"foo"},
|
|
result: pgtype.VarcharArray{
|
|
Elements: []pgtype.Varchar{{String: "foo", Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 1}},
|
|
Status: pgtype.Present},
|
|
},
|
|
{
|
|
source: (([]string)(nil)),
|
|
result: pgtype.VarcharArray{Status: pgtype.Null},
|
|
},
|
|
{
|
|
source: [][]string{{"foo"}, {"bar"}},
|
|
result: pgtype.VarcharArray{
|
|
Elements: []pgtype.Varchar{{String: "foo", Status: pgtype.Present}, {String: "bar", Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 2}, {LowerBound: 1, Length: 1}},
|
|
Status: pgtype.Present},
|
|
},
|
|
{
|
|
source: [][][][]string{{{{"foo", "bar", "baz"}}}, {{{"wibble", "wobble", "wubble"}}}},
|
|
result: pgtype.VarcharArray{
|
|
Elements: []pgtype.Varchar{
|
|
{String: "foo", Status: pgtype.Present},
|
|
{String: "bar", Status: pgtype.Present},
|
|
{String: "baz", Status: pgtype.Present},
|
|
{String: "wibble", Status: pgtype.Present},
|
|
{String: "wobble", Status: pgtype.Present},
|
|
{String: "wubble", Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{
|
|
{LowerBound: 1, Length: 2},
|
|
{LowerBound: 1, Length: 1},
|
|
{LowerBound: 1, Length: 1},
|
|
{LowerBound: 1, Length: 3}},
|
|
Status: pgtype.Present},
|
|
},
|
|
{
|
|
source: [2][1]string{{"foo"}, {"bar"}},
|
|
result: pgtype.VarcharArray{
|
|
Elements: []pgtype.Varchar{{String: "foo", Status: pgtype.Present}, {String: "bar", Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 2}, {LowerBound: 1, Length: 1}},
|
|
Status: pgtype.Present},
|
|
},
|
|
{
|
|
source: [2][1][1][3]string{{{{"foo", "bar", "baz"}}}, {{{"wibble", "wobble", "wubble"}}}},
|
|
result: pgtype.VarcharArray{
|
|
Elements: []pgtype.Varchar{
|
|
{String: "foo", Status: pgtype.Present},
|
|
{String: "bar", Status: pgtype.Present},
|
|
{String: "baz", Status: pgtype.Present},
|
|
{String: "wibble", Status: pgtype.Present},
|
|
{String: "wobble", Status: pgtype.Present},
|
|
{String: "wubble", Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{
|
|
{LowerBound: 1, Length: 2},
|
|
{LowerBound: 1, Length: 1},
|
|
{LowerBound: 1, Length: 1},
|
|
{LowerBound: 1, Length: 3}},
|
|
Status: pgtype.Present},
|
|
},
|
|
}
|
|
|
|
for i, tt := range successfulTests {
|
|
var r pgtype.VarcharArray
|
|
err := r.Set(tt.source)
|
|
if err != nil {
|
|
t.Errorf("%d: %v", i, err)
|
|
}
|
|
|
|
if !reflect.DeepEqual(r, tt.result) {
|
|
t.Errorf("%d: expected %v to convert to %v, but it was %v", i, tt.source, tt.result, r)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestVarcharArrayAssignTo(t *testing.T) {
|
|
var stringSlice []string
|
|
type _stringSlice []string
|
|
var namedStringSlice _stringSlice
|
|
var stringSliceDim2 [][]string
|
|
var stringSliceDim4 [][][][]string
|
|
var stringArrayDim2 [2][1]string
|
|
var stringArrayDim4 [2][1][1][3]string
|
|
|
|
simpleTests := []struct {
|
|
src pgtype.VarcharArray
|
|
dst interface{}
|
|
expected interface{}
|
|
}{
|
|
{
|
|
src: pgtype.VarcharArray{
|
|
Elements: []pgtype.Varchar{{String: "foo", Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 1}},
|
|
Status: pgtype.Present,
|
|
},
|
|
dst: &stringSlice,
|
|
expected: []string{"foo"},
|
|
},
|
|
{
|
|
src: pgtype.VarcharArray{
|
|
Elements: []pgtype.Varchar{{String: "bar", Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 1}},
|
|
Status: pgtype.Present,
|
|
},
|
|
dst: &namedStringSlice,
|
|
expected: _stringSlice{"bar"},
|
|
},
|
|
{
|
|
src: pgtype.VarcharArray{Status: pgtype.Null},
|
|
dst: &stringSlice,
|
|
expected: (([]string)(nil)),
|
|
},
|
|
{
|
|
src: pgtype.VarcharArray{Status: pgtype.Present},
|
|
dst: &stringSlice,
|
|
expected: []string{},
|
|
},
|
|
{
|
|
src: pgtype.VarcharArray{
|
|
Elements: []pgtype.Varchar{{String: "foo", Status: pgtype.Present}, {String: "bar", Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 2}, {LowerBound: 1, Length: 1}},
|
|
Status: pgtype.Present},
|
|
dst: &stringSliceDim2,
|
|
expected: [][]string{{"foo"}, {"bar"}},
|
|
},
|
|
{
|
|
src: pgtype.VarcharArray{
|
|
Elements: []pgtype.Varchar{
|
|
{String: "foo", Status: pgtype.Present},
|
|
{String: "bar", Status: pgtype.Present},
|
|
{String: "baz", Status: pgtype.Present},
|
|
{String: "wibble", Status: pgtype.Present},
|
|
{String: "wobble", Status: pgtype.Present},
|
|
{String: "wubble", Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{
|
|
{LowerBound: 1, Length: 2},
|
|
{LowerBound: 1, Length: 1},
|
|
{LowerBound: 1, Length: 1},
|
|
{LowerBound: 1, Length: 3}},
|
|
Status: pgtype.Present},
|
|
dst: &stringSliceDim4,
|
|
expected: [][][][]string{{{{"foo", "bar", "baz"}}}, {{{"wibble", "wobble", "wubble"}}}},
|
|
},
|
|
{
|
|
src: pgtype.VarcharArray{
|
|
Elements: []pgtype.Varchar{{String: "foo", Status: pgtype.Present}, {String: "bar", Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 2}, {LowerBound: 1, Length: 1}},
|
|
Status: pgtype.Present},
|
|
dst: &stringArrayDim2,
|
|
expected: [2][1]string{{"foo"}, {"bar"}},
|
|
},
|
|
{
|
|
src: pgtype.VarcharArray{
|
|
Elements: []pgtype.Varchar{
|
|
{String: "foo", Status: pgtype.Present},
|
|
{String: "bar", Status: pgtype.Present},
|
|
{String: "baz", Status: pgtype.Present},
|
|
{String: "wibble", Status: pgtype.Present},
|
|
{String: "wobble", Status: pgtype.Present},
|
|
{String: "wubble", Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{
|
|
{LowerBound: 1, Length: 2},
|
|
{LowerBound: 1, Length: 1},
|
|
{LowerBound: 1, Length: 1},
|
|
{LowerBound: 1, Length: 3}},
|
|
Status: pgtype.Present},
|
|
dst: &stringArrayDim4,
|
|
expected: [2][1][1][3]string{{{{"foo", "bar", "baz"}}}, {{{"wibble", "wobble", "wubble"}}}},
|
|
},
|
|
}
|
|
|
|
for i, tt := range simpleTests {
|
|
err := tt.src.AssignTo(tt.dst)
|
|
if err != nil {
|
|
t.Errorf("%d: %v", i, err)
|
|
}
|
|
|
|
if dst := reflect.ValueOf(tt.dst).Elem().Interface(); !reflect.DeepEqual(dst, tt.expected) {
|
|
t.Errorf("%d: expected %v to assign %v, but result was %v", i, tt.src, tt.expected, dst)
|
|
}
|
|
}
|
|
|
|
errorTests := []struct {
|
|
src pgtype.VarcharArray
|
|
dst interface{}
|
|
}{
|
|
{
|
|
src: pgtype.VarcharArray{
|
|
Elements: []pgtype.Varchar{{Status: pgtype.Null}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 1}},
|
|
Status: pgtype.Present,
|
|
},
|
|
dst: &stringSlice,
|
|
},
|
|
{
|
|
src: pgtype.VarcharArray{
|
|
Elements: []pgtype.Varchar{{String: "foo", Status: pgtype.Present}, {String: "bar", Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 1}, {LowerBound: 1, Length: 2}},
|
|
Status: pgtype.Present},
|
|
dst: &stringArrayDim2,
|
|
},
|
|
{
|
|
src: pgtype.VarcharArray{
|
|
Elements: []pgtype.Varchar{{String: "foo", Status: pgtype.Present}, {String: "bar", Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 1}, {LowerBound: 1, Length: 2}},
|
|
Status: pgtype.Present},
|
|
dst: &stringSlice,
|
|
},
|
|
{
|
|
src: pgtype.VarcharArray{
|
|
Elements: []pgtype.Varchar{{String: "foo", Status: pgtype.Present}, {String: "bar", Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 2}, {LowerBound: 1, Length: 1}},
|
|
Status: pgtype.Present},
|
|
dst: &stringArrayDim4,
|
|
},
|
|
}
|
|
|
|
for i, tt := range errorTests {
|
|
err := tt.src.AssignTo(tt.dst)
|
|
if err == nil {
|
|
t.Errorf("%d: expected error but none was returned (%v -> %v)", i, tt.src, tt.dst)
|
|
}
|
|
}
|
|
}
|