mirror of
https://github.com/jackc/pgx.git
synced 2025-05-31 11:42:24 +00:00
af0ca3a39b
Original issue https://github.com/jackc/pgtype/issues/68 This crash occurred in the recursive assignment system used to support multidimensional arrays. This was fixed in 9639a69d451f55456f598c1aa8b93053f8df3088. However, that fix incorrectly used nil instead of an empty slice. In hindsight, it appears the fundamental error is that an assignment to a slice of a type that is not specified is handled with the recursive / reflection path. Or another way of looking at it is as an unexpected feature where []T can now be scanned if individual elements are assignable to T even if []T is not specifically handled. But this new reflection / recursive path did not handle empty arrays. This fix handles the reflection path for an empty slice by allocating an empty slice.
320 lines
11 KiB
Go
320 lines
11 KiB
Go
package pgtype_test
|
|
|
|
import (
|
|
"net"
|
|
"reflect"
|
|
"testing"
|
|
|
|
"github.com/jackc/pgtype"
|
|
"github.com/jackc/pgtype/testutil"
|
|
)
|
|
|
|
func TestInetArrayTranscode(t *testing.T) {
|
|
testutil.TestSuccessfulTranscode(t, "inet[]", []interface{}{
|
|
&pgtype.InetArray{
|
|
Elements: nil,
|
|
Dimensions: nil,
|
|
Status: pgtype.Present,
|
|
},
|
|
&pgtype.InetArray{
|
|
Elements: []pgtype.Inet{
|
|
{IPNet: mustParseCIDR(t, "12.34.56.0/32"), Status: pgtype.Present},
|
|
{Status: pgtype.Null},
|
|
},
|
|
Dimensions: []pgtype.ArrayDimension{{Length: 2, LowerBound: 1}},
|
|
Status: pgtype.Present,
|
|
},
|
|
&pgtype.InetArray{Status: pgtype.Null},
|
|
&pgtype.InetArray{
|
|
Elements: []pgtype.Inet{
|
|
{IPNet: mustParseCIDR(t, "127.0.0.1/32"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "12.34.56.0/32"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "192.168.0.1/32"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "2607:f8b0:4009:80b::200e/128"), Status: pgtype.Present},
|
|
{Status: pgtype.Null},
|
|
{IPNet: mustParseCIDR(t, "255.0.0.0/8"), Status: pgtype.Present},
|
|
},
|
|
Dimensions: []pgtype.ArrayDimension{{Length: 3, LowerBound: 1}, {Length: 2, LowerBound: 1}},
|
|
Status: pgtype.Present,
|
|
},
|
|
&pgtype.InetArray{
|
|
Elements: []pgtype.Inet{
|
|
{IPNet: mustParseCIDR(t, "127.0.0.1/32"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "12.34.56.0/32"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "192.168.0.1/32"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "2607:f8b0:4009:80b::200e/128"), Status: pgtype.Present},
|
|
},
|
|
Dimensions: []pgtype.ArrayDimension{
|
|
{Length: 2, LowerBound: 4},
|
|
{Length: 2, LowerBound: 2},
|
|
},
|
|
Status: pgtype.Present,
|
|
},
|
|
})
|
|
}
|
|
|
|
func TestInetArraySet(t *testing.T) {
|
|
successfulTests := []struct {
|
|
source interface{}
|
|
result pgtype.InetArray
|
|
}{
|
|
{
|
|
source: []*net.IPNet{mustParseCIDR(t, "127.0.0.1/32")},
|
|
result: pgtype.InetArray{
|
|
Elements: []pgtype.Inet{{IPNet: mustParseCIDR(t, "127.0.0.1/32"), Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 1}},
|
|
Status: pgtype.Present},
|
|
},
|
|
{
|
|
source: (([]*net.IPNet)(nil)),
|
|
result: pgtype.InetArray{Status: pgtype.Null},
|
|
},
|
|
{
|
|
source: []net.IP{mustParseCIDR(t, "127.0.0.1/32").IP},
|
|
result: pgtype.InetArray{
|
|
Elements: []pgtype.Inet{{IPNet: mustParseCIDR(t, "127.0.0.1/32"), Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 1}},
|
|
Status: pgtype.Present},
|
|
},
|
|
{
|
|
source: (([]net.IP)(nil)),
|
|
result: pgtype.InetArray{Status: pgtype.Null},
|
|
},
|
|
{
|
|
source: [][]net.IP{{mustParseCIDR(t, "127.0.0.1/32").IP}, {mustParseCIDR(t, "10.0.0.1/32").IP}},
|
|
result: pgtype.InetArray{
|
|
Elements: []pgtype.Inet{
|
|
{IPNet: mustParseCIDR(t, "127.0.0.1/32"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "10.0.0.1/32"), Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 2}, {LowerBound: 1, Length: 1}},
|
|
Status: pgtype.Present},
|
|
},
|
|
{
|
|
source: [][][][]*net.IPNet{
|
|
{{{
|
|
mustParseCIDR(t, "127.0.0.1/24"),
|
|
mustParseCIDR(t, "10.0.0.1/24"),
|
|
mustParseCIDR(t, "172.16.0.1/16")}}},
|
|
{{{
|
|
mustParseCIDR(t, "192.168.0.1/16"),
|
|
mustParseCIDR(t, "224.0.0.1/24"),
|
|
mustParseCIDR(t, "169.168.0.1/16")}}}},
|
|
result: pgtype.InetArray{
|
|
Elements: []pgtype.Inet{
|
|
{IPNet: mustParseCIDR(t, "127.0.0.1/24"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "10.0.0.1/24"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "172.16.0.1/16"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "192.168.0.1/16"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "224.0.0.1/24"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "169.168.0.1/16"), Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{
|
|
{LowerBound: 1, Length: 2},
|
|
{LowerBound: 1, Length: 1},
|
|
{LowerBound: 1, Length: 1},
|
|
{LowerBound: 1, Length: 3}},
|
|
Status: pgtype.Present},
|
|
},
|
|
{
|
|
source: [2][1]net.IP{{mustParseCIDR(t, "127.0.0.1/32").IP}, {mustParseCIDR(t, "10.0.0.1/32").IP}},
|
|
result: pgtype.InetArray{
|
|
Elements: []pgtype.Inet{
|
|
{IPNet: mustParseCIDR(t, "127.0.0.1/32"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "10.0.0.1/32"), Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 2}, {LowerBound: 1, Length: 1}},
|
|
Status: pgtype.Present},
|
|
},
|
|
{
|
|
source: [2][1][1][3]*net.IPNet{
|
|
{{{
|
|
mustParseCIDR(t, "127.0.0.1/24"),
|
|
mustParseCIDR(t, "10.0.0.1/24"),
|
|
mustParseCIDR(t, "172.16.0.1/16")}}},
|
|
{{{
|
|
mustParseCIDR(t, "192.168.0.1/16"),
|
|
mustParseCIDR(t, "224.0.0.1/24"),
|
|
mustParseCIDR(t, "169.168.0.1/16")}}}},
|
|
result: pgtype.InetArray{
|
|
Elements: []pgtype.Inet{
|
|
{IPNet: mustParseCIDR(t, "127.0.0.1/24"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "10.0.0.1/24"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "172.16.0.1/16"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "192.168.0.1/16"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "224.0.0.1/24"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "169.168.0.1/16"), Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{
|
|
{LowerBound: 1, Length: 2},
|
|
{LowerBound: 1, Length: 1},
|
|
{LowerBound: 1, Length: 1},
|
|
{LowerBound: 1, Length: 3}},
|
|
Status: pgtype.Present},
|
|
},
|
|
}
|
|
|
|
for i, tt := range successfulTests {
|
|
var r pgtype.InetArray
|
|
err := r.Set(tt.source)
|
|
if err != nil {
|
|
t.Errorf("%d: %v", i, err)
|
|
}
|
|
|
|
if !reflect.DeepEqual(r, tt.result) {
|
|
t.Errorf("%d: expected %v to convert to %v, but it was %v", i, tt.source, tt.result, r)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestInetArrayAssignTo(t *testing.T) {
|
|
var ipnetSlice []*net.IPNet
|
|
var ipSlice []net.IP
|
|
var ipSliceDim2 [][]net.IP
|
|
var ipnetSliceDim4 [][][][]*net.IPNet
|
|
var ipArrayDim2 [2][1]net.IP
|
|
var ipnetArrayDim4 [2][1][1][3]*net.IPNet
|
|
|
|
simpleTests := []struct {
|
|
src pgtype.InetArray
|
|
dst interface{}
|
|
expected interface{}
|
|
}{
|
|
{
|
|
src: pgtype.InetArray{
|
|
Elements: []pgtype.Inet{{IPNet: mustParseCIDR(t, "127.0.0.1/32"), Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 1}},
|
|
Status: pgtype.Present,
|
|
},
|
|
dst: &ipnetSlice,
|
|
expected: []*net.IPNet{mustParseCIDR(t, "127.0.0.1/32")},
|
|
},
|
|
{
|
|
src: pgtype.InetArray{
|
|
Elements: []pgtype.Inet{{Status: pgtype.Null}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 1}},
|
|
Status: pgtype.Present,
|
|
},
|
|
dst: &ipnetSlice,
|
|
expected: []*net.IPNet{nil},
|
|
},
|
|
{
|
|
src: pgtype.InetArray{
|
|
Elements: []pgtype.Inet{{IPNet: mustParseCIDR(t, "127.0.0.1/32"), Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 1}},
|
|
Status: pgtype.Present,
|
|
},
|
|
dst: &ipSlice,
|
|
expected: []net.IP{mustParseCIDR(t, "127.0.0.1/32").IP},
|
|
},
|
|
{
|
|
src: pgtype.InetArray{
|
|
Elements: []pgtype.Inet{{Status: pgtype.Null}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 1}},
|
|
Status: pgtype.Present,
|
|
},
|
|
dst: &ipSlice,
|
|
expected: []net.IP{nil},
|
|
},
|
|
{
|
|
src: pgtype.InetArray{Status: pgtype.Null},
|
|
dst: &ipnetSlice,
|
|
expected: (([]*net.IPNet)(nil)),
|
|
},
|
|
{
|
|
src: pgtype.InetArray{Status: pgtype.Present},
|
|
dst: &ipnetSlice,
|
|
expected: []*net.IPNet{},
|
|
},
|
|
{
|
|
src: pgtype.InetArray{Status: pgtype.Null},
|
|
dst: &ipSlice,
|
|
expected: (([]net.IP)(nil)),
|
|
},
|
|
{
|
|
src: pgtype.InetArray{Status: pgtype.Present},
|
|
dst: &ipSlice,
|
|
expected: []net.IP{},
|
|
},
|
|
{
|
|
src: pgtype.InetArray{
|
|
Elements: []pgtype.Inet{
|
|
{IPNet: mustParseCIDR(t, "127.0.0.1/32"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "10.0.0.1/32"), Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 2}, {LowerBound: 1, Length: 1}},
|
|
Status: pgtype.Present},
|
|
dst: &ipSliceDim2,
|
|
expected: [][]net.IP{{mustParseCIDR(t, "127.0.0.1/32").IP}, {mustParseCIDR(t, "10.0.0.1/32").IP}},
|
|
},
|
|
{
|
|
src: pgtype.InetArray{
|
|
Elements: []pgtype.Inet{
|
|
{IPNet: mustParseCIDR(t, "127.0.0.1/24"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "10.0.0.1/24"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "172.16.0.1/16"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "192.168.0.1/16"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "224.0.0.1/24"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "169.168.0.1/16"), Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{
|
|
{LowerBound: 1, Length: 2},
|
|
{LowerBound: 1, Length: 1},
|
|
{LowerBound: 1, Length: 1},
|
|
{LowerBound: 1, Length: 3}},
|
|
Status: pgtype.Present},
|
|
dst: &ipnetSliceDim4,
|
|
expected: [][][][]*net.IPNet{
|
|
{{{
|
|
mustParseCIDR(t, "127.0.0.1/24"),
|
|
mustParseCIDR(t, "10.0.0.1/24"),
|
|
mustParseCIDR(t, "172.16.0.1/16")}}},
|
|
{{{
|
|
mustParseCIDR(t, "192.168.0.1/16"),
|
|
mustParseCIDR(t, "224.0.0.1/24"),
|
|
mustParseCIDR(t, "169.168.0.1/16")}}}},
|
|
},
|
|
{
|
|
src: pgtype.InetArray{
|
|
Elements: []pgtype.Inet{
|
|
{IPNet: mustParseCIDR(t, "127.0.0.1/32"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "10.0.0.1/32"), Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{{LowerBound: 1, Length: 2}, {LowerBound: 1, Length: 1}},
|
|
Status: pgtype.Present},
|
|
dst: &ipArrayDim2,
|
|
expected: [2][1]net.IP{{mustParseCIDR(t, "127.0.0.1/32").IP}, {mustParseCIDR(t, "10.0.0.1/32").IP}},
|
|
},
|
|
{
|
|
src: pgtype.InetArray{
|
|
Elements: []pgtype.Inet{
|
|
{IPNet: mustParseCIDR(t, "127.0.0.1/24"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "10.0.0.1/24"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "172.16.0.1/16"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "192.168.0.1/16"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "224.0.0.1/24"), Status: pgtype.Present},
|
|
{IPNet: mustParseCIDR(t, "169.168.0.1/16"), Status: pgtype.Present}},
|
|
Dimensions: []pgtype.ArrayDimension{
|
|
{LowerBound: 1, Length: 2},
|
|
{LowerBound: 1, Length: 1},
|
|
{LowerBound: 1, Length: 1},
|
|
{LowerBound: 1, Length: 3}},
|
|
Status: pgtype.Present},
|
|
dst: &ipnetArrayDim4,
|
|
expected: [2][1][1][3]*net.IPNet{
|
|
{{{
|
|
mustParseCIDR(t, "127.0.0.1/24"),
|
|
mustParseCIDR(t, "10.0.0.1/24"),
|
|
mustParseCIDR(t, "172.16.0.1/16")}}},
|
|
{{{
|
|
mustParseCIDR(t, "192.168.0.1/16"),
|
|
mustParseCIDR(t, "224.0.0.1/24"),
|
|
mustParseCIDR(t, "169.168.0.1/16")}}}},
|
|
},
|
|
}
|
|
|
|
for i, tt := range simpleTests {
|
|
err := tt.src.AssignTo(tt.dst)
|
|
if err != nil {
|
|
t.Errorf("%d: %v", i, err)
|
|
}
|
|
|
|
if dst := reflect.ValueOf(tt.dst).Elem().Interface(); !reflect.DeepEqual(dst, tt.expected) {
|
|
t.Errorf("%d: expected %v to assign %v, but result was %v", i, tt.src, tt.expected, dst)
|
|
}
|
|
}
|
|
}
|