Fix: RowToStructByPos with embedded unexported struct

https://github.com/jackc/pgx/issues/1583

rows.go

@@ -533,13 +533,11 @@ func (rs *positionalStructRowScanner) appendScanTargets(dstElemValue reflect.Val
 
 	for i := 0; i < dstElemType.NumField(); i++ {
 		sf := dstElemType.Field(i)
-		if sf.PkgPath == "" {
+		// Handle anonymous struct embedding, but do not try to handle embedded pointers.
-			// Handle anonymous struct embedding, but do not try to handle embedded pointers.
+		if sf.Anonymous && sf.Type.Kind() == reflect.Struct {
-			if sf.Anonymous && sf.Type.Kind() == reflect.Struct {
+			scanTargets = rs.appendScanTargets(dstElemValue.Field(i), scanTargets)
-				scanTargets = rs.appendScanTargets(dstElemValue.Field(i), scanTargets)
+		} else if sf.PkgPath == "" {
-			} else {
+			scanTargets = append(scanTargets, dstElemValue.Field(i).Addr().Interface())
-				scanTargets = append(scanTargets, dstElemValue.Field(i).Addr().Interface())
-			}
 		}
 	}
 

rows_test.go

@@ -411,6 +411,31 @@ func TestRowToStructByPosMultipleEmbeddedStruct(t *testing.T) {
 	})
 }
 
+func TestRowToStructByPosEmbeddedUnexportedStruct(t *testing.T) {
+	type name struct {
+		First string
+		Last  string
+	}
+
+	type person struct {
+		name
+		Age int32
+	}
+
+	defaultConnTestRunner.RunTest(context.Background(), t, func(ctx context.Context, t testing.TB, conn *pgx.Conn) {
+		rows, _ := conn.Query(ctx, `select 'John' as first_name, 'Smith' as last_name, n as age from generate_series(0, 9) n`)
+		slice, err := pgx.CollectRows(rows, pgx.RowToStructByPos[person])
+		require.NoError(t, err)
+
+		assert.Len(t, slice, 10)
+		for i := range slice {
+			assert.Equal(t, "John", slice[i].name.First)
+			assert.Equal(t, "Smith", slice[i].name.Last)
+			assert.EqualValues(t, i, slice[i].Age)
+		}
+	})
+}
+
 // Pointer to struct is not supported. But check that we don't panic.
 func TestRowToStructByPosEmbeddedPointerToStruct(t *testing.T) {
 	type Name struct {