GOMODULES
/
pgx
mirror of https://github.com/jackc/pgx.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove another malloc from query path

pull/483/head
Jack Christensen 2019-05-04 09:01:57 -05:00
parent db68713809
commit dd571cf345
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
conn.go
View File

@ -51,6 +51,7 @@ type Conn struct {
preallocatedRows []connRows preallocatedRows []connRows
paramFormats []int16 paramFormats []int16
paramValues [][]byte paramValues [][]byte
resultFormats []int16
} }
// PreparedStatement is a description of a prepared statement // PreparedStatement is a description of a prepared statement
@ -161,6 +162,7 @@ func connect(ctx context.Context, config *ConnConfig) (c *Conn, err error) {
c.wbuf = make([]byte, 0, 1024) c.wbuf = make([]byte, 0, 1024)
c.paramFormats = make([]int16, 0, 16) c.paramFormats = make([]int16, 0, 16)
c.paramValues = make([][]byte, 0, 16) c.paramValues = make([][]byte, 0, 16)
c.resultFormats = make([]int16, 0, 32)
// Replication connections can't execute the queries to // Replication connections can't execute the queries to
// populate the c.PgTypes and c.pgsqlAfInet // populate the c.PgTypes and c.pgsqlAfInet
@ -680,7 +682,12 @@ optionLoop:
} }
if resultFormats == nil { if resultFormats == nil {
resultFormats = make([]int16, len(ps.FieldDescriptions)) if len(ps.FieldDescriptions) > cap(c.resultFormats) {
resultFormats = make([]int16, len(ps.FieldDescriptions))
} else {
resultFormats = c.resultFormats[:len(ps.FieldDescriptions)]
}
for i := range resultFormats { for i := range resultFormats {
if dt, ok := c.ConnInfo.DataTypeForOID(ps.FieldDescriptions[i].DataType); ok { if dt, ok := c.ConnInfo.DataTypeForOID(ps.FieldDescriptions[i].DataType); ok {
if _, ok := dt.Value.(pgtype.BinaryDecoder); ok { if _, ok := dt.Value.(pgtype.BinaryDecoder); ok {