Fix: driver.Value representation of bytea should be []byte not string

https://github.com/jackc/pgx/issues/1445

pgtype/bytea.go

@@ -238,7 +238,7 @@ func decodeHexBytea(src []byte) ([]byte, error) {
 }
 
 func (c ByteaCodec) DecodeDatabaseSQLValue(m *Map, oid uint32, format int16, src []byte) (driver.Value, error) {
-	return codecDecodeToTextFormat(c, m, oid, format, src)
+	return c.DecodeValue(m, oid, format, src)
 }
 
 func (c ByteaCodec) DecodeValue(m *Map, oid uint32, format int16, src []byte) (any, error) {

pgtype/bytea_test.go

@@ -3,6 +3,7 @@ package pgtype_test
 import (
 	"bytes"
 	"context"
+	"fmt"
 	"testing"
 
 	pgx "github.com/jackc/pgx/v5"
@@ -114,3 +115,23 @@ func TestUndecodedBytes(t *testing.T) {
 		require.Equal(t, buf, []byte{0, 0, 0, 1})
 	})
 }
+
+func TestByteaCodecDecodeDatabaseSQLValue(t *testing.T) {
+	defaultConnTestRunner.RunTest(context.Background(), t, func(ctx context.Context, t testing.TB, conn *pgx.Conn) {
+		var buf []byte
+		err := conn.QueryRow(ctx, `select '\xa1b2c3d4'::bytea`).Scan(sqlScannerFunc(func(src any) error {
+			switch src := src.(type) {
+			case []byte:
+				buf = make([]byte, len(src))
+				copy(buf, src)
+				return nil
+			default:
+				return fmt.Errorf("expected []byte, got %T", src)
+			}
+		}))
+		require.NoError(t, err)
+
+		require.Len(t, buf, 4)
+		require.Equal(t, buf, []byte{0xa1, 0xb2, 0xc3, 0xd4})
+	})
+}

pgtype/pgtype_test.go

@@ -120,6 +120,13 @@ func skipPostgreSQLVersionLessThan(t testing.TB, minVersion int64) {
 	}
 }
 
+// sqlScannerFunc lets an arbitrary function be used as a sql.Scanner.
+type sqlScannerFunc func(src any) error
+
+func (f sqlScannerFunc) Scan(src any) error {
+	return f(src)
+}
+
 func TestMapScanNilIsNoOp(t *testing.T) {
 	m := pgtype.NewMap()