GOMODULES
/
pgx
mirror of https://github.com/jackc/pgx.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use pgtype.PreallocBytes in LargeObject's Read. 

Fixes #1876.
pull/2013/head
Mitar 2024-05-12 22:17:43 +02:00 committed by Jack Christensen
parent 523411a3fb
commit c81bba8690
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
large_objects.go
View File

@ -4,6 +4,8 @@ import (
"context" "context"
"errors" "errors"
"io" "io"
"github.com/jackc/pgx/v5/pgtype"
) )
// The PostgreSQL wire protocol has a limit of 1 GB - 1 per message. See definition of // The PostgreSQL wire protocol has a limit of 1 GB - 1 per message. See definition of
@ -115,9 +117,10 @@ func (o *LargeObject) Read(p []byte) (int, error) {
expected = maxLargeObjectMessageLength expected = maxLargeObjectMessageLength
} }
var res []byte res := pgtype.PreallocBytes(p[nTotal:])
err := o.tx.QueryRow(o.ctx, "select loread($1, $2)", o.fd, expected).Scan(&res) err := o.tx.QueryRow(o.ctx, "select loread($1, $2)", o.fd, expected).Scan(&res)
copy(p[nTotal:], res) // We compute expected so that it always fits into p, so it should never happen
// that PreallocBytes's ScanBytes had to allocate a new slice.
nTotal += len(res) nTotal += len(res)
if err != nil { if err != nil {
return nTotal, err return nTotal, err