GOMODULES
/
pgx
mirror of https://github.com/jackc/pgx.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Tweak benchmarks to account for slow binary formats 

See https://www.postgresql.org/message-id/CAMovtNoHFod2jMAKQjjxv209PCTJx5Kc66anwWvX0mEiaXwgmA%40mail.gmail.com
pull/761/head
Jack Christensen 2020-05-25 11:18:08 -05:00
parent 8faa1f5096
commit bcdbb9f657
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
bench_test.go
View File

@ -1103,7 +1103,7 @@ func BenchmarkSelectRowsScanDecoder(b *testing.B) {
} }
} }
func BenchmarkSelectRowsExplicitBinaryDecoding(b *testing.B) { func BenchmarkSelectRowsExplicitDecoding(b *testing.B) {
conn := mustConnectString(b, os.Getenv("PGX_TEST_DATABASE")) conn := mustConnectString(b, os.Getenv("PGX_TEST_DATABASE"))
defer closeConn(b, conn) defer closeConn(b, conn)
@ -1126,17 +1126,17 @@ func BenchmarkSelectRowsExplicitBinaryDecoding(b *testing.B) {
b.Fatal(err) b.Fatal(err)
} }
err = br.FirstName.DecodeBinary(conn.ConnInfo(), rawValues[1]) err = br.FirstName.DecodeText(conn.ConnInfo(), rawValues[1])
if err != nil { if err != nil {
b.Fatal(err) b.Fatal(err)
} }
err = br.LastName.DecodeBinary(conn.ConnInfo(), rawValues[2]) err = br.LastName.DecodeText(conn.ConnInfo(), rawValues[2])
if err != nil { if err != nil {
b.Fatal(err) b.Fatal(err)
} }
err = br.Sex.DecodeBinary(conn.ConnInfo(), rawValues[3]) err = br.Sex.DecodeText(conn.ConnInfo(), rawValues[3])
if err != nil { if err != nil {
b.Fatal(err) b.Fatal(err)
} }
@ -1209,7 +1209,7 @@ func BenchmarkSelectRowsPgConnExecParams(b *testing.B) {
code int16 code int16
}{ }{
{"text", pgx.TextFormatCode}, {"text", pgx.TextFormatCode},
{"binary", pgx.BinaryFormatCode}, {"binary - mostly", pgx.BinaryFormatCode},
} }
for _, format := range formats { for _, format := range formats {
b.Run(format.name, func(b *testing.B) { b.Run(format.name, func(b *testing.B) {
@ -1220,7 +1220,7 @@ func BenchmarkSelectRowsPgConnExecParams(b *testing.B) {
[][]byte{[]byte(strconv.FormatInt(rowCount, 10))}, [][]byte{[]byte(strconv.FormatInt(rowCount, 10))},
nil, nil,
nil, nil,
[]int16{format.code}, []int16{format.code, pgx.TextFormatCode, pgx.TextFormatCode, pgx.TextFormatCode, format.code, format.code, format.code, format.code},
) )
for rr.NextRow() { for rr.NextRow() {
rr.Values() rr.Values()
@ -1255,7 +1255,7 @@ func BenchmarkSelectRowsPgConnExecPrepared(b *testing.B) {
code int16 code int16
}{ }{
{"text", pgx.TextFormatCode}, {"text", pgx.TextFormatCode},
{"binary", pgx.BinaryFormatCode}, {"binary - mostly", pgx.BinaryFormatCode},
} }
for _, format := range formats { for _, format := range formats {
b.Run(format.name, func(b *testing.B) { b.Run(format.name, func(b *testing.B) {
@ -1265,7 +1265,7 @@ func BenchmarkSelectRowsPgConnExecPrepared(b *testing.B) {
"ps1", "ps1",
[][]byte{[]byte(strconv.FormatInt(rowCount, 10))}, [][]byte{[]byte(strconv.FormatInt(rowCount, 10))},
nil, nil,
[]int16{format.code}, []int16{format.code, pgx.TextFormatCode, pgx.TextFormatCode, pgx.TextFormatCode, format.code, format.code, format.code, format.code},
) )
for rr.NextRow() { for rr.NextRow() {
rr.Values() rr.Values()