GOMODULES/pgx
1
0
Fork 0
mirror of https://github.com/jackc/pgx.git synced 2025-05-31 11:42:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Re-enable domain type test

Browse Source
This commit is contained in:
Jack Christensen 2022-02-12 09:35:52 -06:00
parent 4b6d527b0b
commit a14f3f291f
1 changed files with 9 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
conn_test.go
View File

@ -874,28 +874,18 @@ func TestUnregisteredTypeUsableAsStringArgumentAndBaseResult(t *testing.T) {
} }
func TestDomainType(t *testing.T) { func TestDomainType(t *testing.T) {
t.Skip("TODO - unskip later in v5")
testWithAndWithoutPreferSimpleProtocol(t, func(t *testing.T, conn *pgx.Conn) { testWithAndWithoutPreferSimpleProtocol(t, func(t *testing.T, conn *pgx.Conn) {
skipCockroachDB(t, conn, "Server does support domain types (https://github.com/cockroachdb/cockroach/issues/27796)") skipCockroachDB(t, conn, "Server does support domain types (https://github.com/cockroachdb/cockroach/issues/27796)")
var n uint64
// Domain type uint64 is a PostgreSQL domain of underlying type numeric. // Domain type uint64 is a PostgreSQL domain of underlying type numeric.
err := conn.QueryRow(context.Background(), "select $1::uint64", uint64(24)).Scan(&n) // Unregistered type can be used as string.
var s string
err := conn.QueryRow(context.Background(), "select $1::uint64", "24").Scan(&s)
require.NoError(t, err) require.NoError(t, err)
require.Equal(t, "24", s)
// A string can be used. But a string cannot be the result because the describe result from the PostgreSQL server gives // Register type
// the underlying type of numeric.
err = conn.QueryRow(context.Background(), "select $1::uint64", "42").Scan(&n)
if err != nil {
t.Fatal(err)
}
if n != 42 {
t.Fatalf("Expected n to be 42, but was %v", n)
}
var uint64OID uint32 var uint64OID uint32
err = conn.QueryRow(context.Background(), "select t.oid from pg_type t where t.typname='uint64';").Scan(&uint64OID) err = conn.QueryRow(context.Background(), "select t.oid from pg_type t where t.typname='uint64';").Scan(&uint64OID)
if err != nil { if err != nil {
@ -903,6 +893,10 @@ func TestDomainType(t *testing.T) {
} }
conn.ConnInfo().RegisterDataType(pgtype.DataType{Name: "uint64", OID: uint64OID, Codec: pgtype.NumericCodec{}}) conn.ConnInfo().RegisterDataType(pgtype.DataType{Name: "uint64", OID: uint64OID, Codec: pgtype.NumericCodec{}})
var n uint64
err = conn.QueryRow(context.Background(), "select $1::uint64", uint64(24)).Scan(&n)
require.NoError(t, err)
// String is still an acceptable argument after registration // String is still an acceptable argument after registration
err = conn.QueryRow(context.Background(), "select $1::uint64", "7").Scan(&n) err = conn.QueryRow(context.Background(), "select $1::uint64", "7").Scan(&n)
if err != nil { if err != nil {
@ -911,15 +905,6 @@ func TestDomainType(t *testing.T) {
if n != 7 { if n != 7 {
t.Fatalf("Expected n to be 7, but was %v", n) t.Fatalf("Expected n to be 7, but was %v", n)
} }
// But a uint64 is acceptable
err = conn.QueryRow(context.Background(), "select $1::uint64", uint64(24)).Scan(&n)
if err != nil {
t.Fatal(err)
}
if n != 24 {
t.Fatalf("Expected n to be 24, but was %v", n)
}
}) })
} }