GOMODULES/pgx
1
0
Fork 0
mirror of https://github.com/jackc/pgx.git synced 2025-05-23 16:01:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix flickering test in CI

Browse Source 
While this test always worked on my machine, it flickered in CI. And to
be fair the test can't guarantee the condition it is testing. Work
around this by trying many times before admitting failure.
This commit is contained in:
Jack Christensen 2022-06-25 16:05:20 -05:00
parent 72b1dcff2f
commit 9afd320b9e
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
internal/iobufpool/iobufpool_test.go
View File

@ -5,7 +5,6 @@ import (
"github.com/jackc/pgx/v5/internal/iobufpool"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestGetCap(t *testing.T) {
@ -70,9 +69,17 @@ func TestPutHandlesWrongSizedBuffers(t *testing.T) {
}
func TestPutGetBufferReuse(t *testing.T) {
buf := iobufpool.Get(4)
buf[0] = 1
iobufpool.Put(buf)
buf = iobufpool.Get(4)
require.Equal(t, byte(1), buf[0])
// There is no way to guarantee a buffer will be reused. It should be, but a GC between the Put and the Get will cause
// it not to be. So try many times.
for i := 0; i < 100000; i++ {
buf := iobufpool.Get(4)
buf[0] = 1
iobufpool.Put(buf)
buf = iobufpool.Get(4)
if buf[0] == 1 {
return
}
}
t.Error("buffer was never reused")
}