Use envvars for stdlib tests

pull/586/head
Jack Christensen 2019-05-20 20:39:45 -05:00
parent 29f02807b0
commit 98f3e64bec
3 changed files with 7 additions and 4 deletions

View File

@ -7,6 +7,7 @@ import (
"database/sql/driver" "database/sql/driver"
"encoding/json" "encoding/json"
"math" "math"
"os"
"reflect" "reflect"
"testing" "testing"
"time" "time"
@ -75,7 +76,7 @@ func closeStmt(t *testing.T, stmt *sql.Stmt) {
} }
func TestSQLOpen(t *testing.T) { func TestSQLOpen(t *testing.T) {
db, err := sql.Open("pgx", "postgres://pgx_md5:secret@127.0.0.1:5432/pgx_test") db, err := sql.Open("pgx", os.Getenv("PGX_TEST_DATABASE"))
if err != nil { if err != nil {
t.Fatalf("sql.Open failed: %v", err) t.Fatalf("sql.Open failed: %v", err)
} }
@ -1055,7 +1056,7 @@ func TestRowsColumnTypes(t *testing.T) {
} }
func TestSimpleQueryLifeCycle(t *testing.T) { func TestSimpleQueryLifeCycle(t *testing.T) {
config, err := pgx.ParseConfig("postgres://pgx_md5:secret@127.0.0.1:5432/pgx_test") config, err := pgx.ParseConfig(os.Getenv("PGX_TEST_DATABASE"))
if err != nil { if err != nil {
t.Fatalf("pgx.ParseConnectionString failed: %v", err) t.Fatalf("pgx.ParseConnectionString failed: %v", err)
} }

View File

@ -4,6 +4,7 @@ package stdlib_test
import ( import (
"database/sql" "database/sql"
"os"
"testing" "testing"
"github.com/jackc/pgx/v4" "github.com/jackc/pgx/v4"
@ -11,7 +12,7 @@ import (
) )
func openDB(t *testing.T) *sql.DB { func openDB(t *testing.T) *sql.DB {
config, err := pgx.ParseConfig("postgres://pgx_md5:secret@127.0.0.1:5432/pgx_test") config, err := pgx.ParseConfig(os.Getenv("PGX_TEST_DATABASE"))
if err != nil { if err != nil {
t.Fatalf("pgx.ParseConnectionString failed: %v", err) t.Fatalf("pgx.ParseConnectionString failed: %v", err)
} }

View File

@ -4,12 +4,13 @@ package stdlib_test
import ( import (
"database/sql" "database/sql"
"os"
"testing" "testing"
) )
// this file contains utility functions for tests that differ between versions. // this file contains utility functions for tests that differ between versions.
func openDB(t *testing.T) *sql.DB { func openDB(t *testing.T) *sql.DB {
db, err := sql.Open("pgx", "postgres://pgx_md5:secret@127.0.0.1:5432/pgx_test") db, err := sql.Open("pgx", os.Getenv("PGX_TEST_DATABASE"))
if err != nil { if err != nil {
t.Fatalf("sql.Open failed: %v", err) t.Fatalf("sql.Open failed: %v", err)
} }