Add driver.Pinger support to stdlib.Conn

batch-wip
Jack Christensen 2017-05-19 08:54:08 -05:00
parent e1397613fd
commit 936cb68866
2 changed files with 58 additions and 0 deletions

View File

@ -336,6 +336,14 @@ func (c *Conn) queryPreparedContext(ctx context.Context, name string, argsV []dr
return &Rows{rows: rows}, nil
}
func (c *Conn) Ping(ctx context.Context) error {
if !c.conn.IsAlive() {
return driver.ErrBadConn
}
return c.conn.Ping(ctx)
}
// Anything that isn't a database/sql compatible type needs to be forced to
// text format so that pgx.Rows.Values doesn't decode it into a native type
// (e.g. []int32)

View File

@ -6,6 +6,7 @@ import (
"database/sql"
"fmt"
"testing"
"time"
"github.com/jackc/pgx"
"github.com/jackc/pgx/pgmock"
@ -827,3 +828,52 @@ func TestAcquireConn(t *testing.T) {
ensureConnValid(t, db)
}
func TestConnPingContextSuccess(t *testing.T) {
db := openDB(t)
defer closeDB(t, db)
if err := db.PingContext(context.Background()); err != nil {
t.Fatalf("db.PingContext failed: %v", err)
}
ensureConnValid(t, db)
}
func TestConnPingContextCancel(t *testing.T) {
script := &pgmock.Script{
Steps: pgmock.AcceptUnauthenticatedConnRequestSteps(),
}
script.Steps = append(script.Steps, pgmock.PgxInitSteps()...)
script.Steps = append(script.Steps,
pgmock.ExpectMessage(&pgproto3.Query{String: ";"}),
)
server, err := pgmock.NewServer(script)
if err != nil {
t.Fatal(err)
}
defer server.Close()
errChan := make(chan error)
go func() {
errChan <- server.ServeOne()
}()
db, err := sql.Open("pgx", fmt.Sprintf("postgres://pgx_md5:secret@%s/pgx_test?sslmode=disable", server.Addr()))
if err != nil {
t.Fatalf("sql.Open failed: %v", err)
}
// defer closeDB(t, db) // mock DB doesn't close correctly yet
ctx, _ := context.WithTimeout(context.Background(), 100*time.Millisecond)
err = db.PingContext(ctx)
if err != context.DeadlineExceeded {
t.Errorf("err => %v, want %v", err, context.DeadlineExceeded)
}
if err := <-errChan; err != nil {
t.Errorf("mock server err: %v", err)
}
}