GOMODULES/pgx
1
0
Fork 0
mirror of https://github.com/jackc/pgx.git synced 2025-04-28 05:37:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add arguments count check to execParamsAndPreparedPrefix

Browse Source
This commit is contained in:
malstoun 2020-01-03 19:43:19 +03:00
parent 9cb58fc969
commit 8dc8431ef9
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
conn.go
View File

@ -501,6 +501,10 @@ func (c *Conn) execSimpleProtocol(ctx context.Context, sql string, arguments []i
} }
func (c *Conn) execParamsAndPreparedPrefix(sd *pgconn.StatementDescription, arguments []interface{}) error { func (c *Conn) execParamsAndPreparedPrefix(sd *pgconn.StatementDescription, arguments []interface{}) error {
if len(sd.ParamOIDs) != len(arguments) {
return errors.Errorf("expected %d arguments, got %d", len(sd.ParamOIDs), len(arguments))
}
c.eqb.Reset() c.eqb.Reset()
args, err := convertDriverValuers(arguments) args, err := convertDriverValuers(arguments)

6
conn_test.go
View File

@ -200,6 +200,12 @@ func TestExecFailureWithArguments(t *testing.T) {
t.Fatal("Expected SQL syntax error") t.Fatal("Expected SQL syntax error")
} }
assert.False(t, pgconn.SafeToRetry(err)) assert.False(t, pgconn.SafeToRetry(err))
_, err = conn.Exec(context.Background(), "select $1::varchar(1);", "1", "2")
if err == nil {
t.Fatal("Expected pgx arguments count error", err)
}
assert.Equal(t, "expected 1 arguments, got 2", err.Error())
} }
func TestExecContextWithoutCancelation(t *testing.T) { func TestExecContextWithoutCancelation(t *testing.T) {