GOMODULES/pgx
1
0
Fork 0
mirror of https://github.com/jackc/pgx.git synced 2025-05-31 11:42:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add irreversible migration catching

Browse Source
This commit is contained in:
Jack Christensen 2014-04-18 23:40:19 -05:00
parent d6614c4e3a
commit 7ef0136d2d
2 changed files with 35 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
migrate/migrate.go
View File

@ -11,6 +11,14 @@ func (e BadVersionError) Error() string {
return string(e) return string(e)
} }
type IrreversibleMigrationError struct {
m *Migration
}
func (e IrreversibleMigrationError) Error() string {
return fmt.Sprintf("Irreversible migration: %d - %s", e.m.Sequence, e.m.Name)
}
type Migration struct { type Migration struct {
Sequence int32 Sequence int32
Name string Name string
@ -88,6 +96,9 @@ func (m *Migrator) MigrateTo(targetVersion int32) (err error) {
sequence = current.Sequence - 1 sequence = current.Sequence - 1
sql = current.DownSQL sql = current.DownSQL
directionName = "down" directionName = "down"
if current.DownSQL == "" {
return IrreversibleMigrationError{m: current}
}
} }
var innerErr error var innerErr error

34
migrate/migrate_test.go
View File

@ -111,7 +111,7 @@ func (s *MigrateSuite) TestMigrate(c *C) {
c.Assert(currentVersion, Equals, int32(3)) c.Assert(currentVersion, Equals, int32(3))
} }
func (s *MigrateSuite) TestMigrateTo(c *C) { func (s *MigrateSuite) TestMigrateToLifeCycle(c *C) {
m := s.createSampleMigrator(c) m := s.createSampleMigrator(c)
var onStartCallUpCount int var onStartCallUpCount int
@ -127,16 +127,8 @@ func (s *MigrateSuite) TestMigrateTo(c *C) {
} }
} }
// Migrate to -1 is error
err := m.MigrateTo(-1)
c.Assert(err, ErrorMatches, "schema_version version -1 is outside the valid versions of 0 to 3")
// Migrate past end is error
err = m.MigrateTo(int32(len(m.Migrations)) + 1)
c.Assert(err, ErrorMatches, "schema_version version 4 is outside the valid versions of 0 to 3")
// Migrate from 0 up to 1 // Migrate from 0 up to 1
err = m.MigrateTo(1) err := m.MigrateTo(1)
c.Assert(err, IsNil) c.Assert(err, IsNil)
currentVersion := s.SelectValue(c, "select version from schema_version") currentVersion := s.SelectValue(c, "select version from schema_version")
c.Assert(currentVersion, Equals, int32(1)) c.Assert(currentVersion, Equals, int32(1))
@ -201,6 +193,28 @@ func (s *MigrateSuite) TestMigrateTo(c *C) {
c.Assert(onStartCallUpCount, Equals, 6) c.Assert(onStartCallUpCount, Equals, 6)
c.Assert(onStartCallDownCount, Equals, 3) c.Assert(onStartCallDownCount, Equals, 3)
} }
func (s *MigrateSuite) TestMigrateToBoundaries(c *C) {
m := s.createSampleMigrator(c)
// Migrate to -1 is error
err := m.MigrateTo(-1)
c.Assert(err, ErrorMatches, "schema_version version -1 is outside the valid versions of 0 to 3")
// Migrate past end is error
err = m.MigrateTo(int32(len(m.Migrations)) + 1)
c.Assert(err, ErrorMatches, "schema_version version 4 is outside the valid versions of 0 to 3")
}
func (s *MigrateSuite) TestMigrateToIrreversible(c *C) {
m := s.createEmptyMigrator(c)
m.AppendMigration("Foo", "drop table if exists t3", "")
err := m.MigrateTo(1)
c.Assert(err, IsNil)
err = m.MigrateTo(0)
c.Assert(err, ErrorMatches, "Irreversible migration: 1 - Foo")
}
func Example_OnStartMigrationProgressLogging() { func Example_OnStartMigrationProgressLogging() {
conn, err := pgx.Connect(*defaultConnectionParameters) conn, err := pgx.Connect(*defaultConnectionParameters)