diff --git a/internal/iobufpool/iobufpool_test.go b/internal/iobufpool/iobufpool_test.go index 09e258bb..a293f975 100644 --- a/internal/iobufpool/iobufpool_test.go +++ b/internal/iobufpool/iobufpool_test.go @@ -30,15 +30,15 @@ func TestGetCap(t *testing.T) { } for _, tt := range tests { buf := iobufpool.Get(tt.requestedLen) - assert.Equalf(t, tt.requestedLen, len(buf), "bad len for requestedLen: %d", len(buf), tt.requestedLen) - assert.Equalf(t, tt.expectedCap, cap(buf), "bad cap for requestedLen: %d", tt.requestedLen) + assert.Equalf(t, tt.requestedLen, len(*buf), "bad len for requestedLen: %d", len(*buf), tt.requestedLen) + assert.Equalf(t, tt.expectedCap, cap(*buf), "bad cap for requestedLen: %d", tt.requestedLen) } } func TestPutHandlesWrongSizedBuffers(t *testing.T) { for putBufSize := range []int{0, 1, 128, 250, 256, 257, 1023, 1024, 1025, 1 << 28} { putBuf := make([]byte, putBufSize) - iobufpool.Put(putBuf) + iobufpool.Put(&putBuf) tests := []struct { requestedLen int @@ -62,8 +62,8 @@ func TestPutHandlesWrongSizedBuffers(t *testing.T) { } for _, tt := range tests { getBuf := iobufpool.Get(tt.requestedLen) - assert.Equalf(t, tt.requestedLen, len(getBuf), "len(putBuf): %d, requestedLen: %d", len(putBuf), tt.requestedLen) - assert.Equalf(t, tt.expectedCap, cap(getBuf), "cap(putBuf): %d, requestedLen: %d", cap(putBuf), tt.requestedLen) + assert.Equalf(t, tt.requestedLen, len(*getBuf), "len(putBuf): %d, requestedLen: %d", len(putBuf), tt.requestedLen) + assert.Equalf(t, tt.expectedCap, cap(*getBuf), "cap(putBuf): %d, requestedLen: %d", cap(putBuf), tt.requestedLen) } } } @@ -73,10 +73,10 @@ func TestPutGetBufferReuse(t *testing.T) { // it not to be. So try many times. for i := 0; i < 100000; i++ { buf := iobufpool.Get(4) - buf[0] = 1 + (*buf)[0] = 1 iobufpool.Put(buf) buf = iobufpool.Get(4) - if buf[0] == 1 { + if (*buf)[0] == 1 { return } } diff --git a/pgproto3/chunkreader_test.go b/pgproto3/chunkreader_test.go index 41c8ce65..e1c2b0da 100644 --- a/pgproto3/chunkreader_test.go +++ b/pgproto3/chunkreader_test.go @@ -29,7 +29,7 @@ func TestChunkReaderNextDoesNotReadIfAlreadyBuffered(t *testing.T) { t.Fatalf("Expected read bytes to be %v, but they were %v", src[2:4], n2) } - if bytes.Compare(r.buf[:len(src)], src) != 0 { + if bytes.Compare((*r.buf)[:len(src)], src) != 0 { t.Fatalf("Expected r.buf to be %v, but it was %v", src, r.buf) }