diff --git a/values.go b/values.go index fe8f82fa..cf3a0266 100644 --- a/values.go +++ b/values.go @@ -3176,9 +3176,11 @@ func decodeAclItemArray(vr *ValueReader) []AclItem { // remove the '{' at the front and the '}' at the end str = str[1 : len(str)-1] - strs, _ := ParseAclItemArray(str) - // XXX: what do I do with the error here? - // XXX strs := strings.Split(str, ",") + strs, err := ParseAclItemArray(str) + if err != nil { + vr.Fatal(ProtocolError(err.Error())) + return nil + } // cast strings into AclItems before returning aclitems := make([]AclItem, len(strs)) diff --git a/values_test.go b/values_test.go index 8c5d1032..bbb22f24 100644 --- a/values_test.go +++ b/values_test.go @@ -649,7 +649,6 @@ func assertAclItemSlicesEqual(t *testing.T, query, scan []pgx.AclItem) { } } -// XXX func TestAclArrayDecoding(t *testing.T) { t.Parallel()