GOMODULES
/
pgx
mirror of https://github.com/jackc/pgx.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

update description cache after exec prepare

pull/1856/head
James Hartig 2023-12-22 15:03:54 -06:00 committed by Jack Christensen
parent 22fe50149b
commit 4c14caae07
2 changed files with 24 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
conn.go
View File

@ -513,6 +513,7 @@ optionLoop:
if err != nil { if err != nil {
return pgconn.CommandTag{}, err return pgconn.CommandTag{}, err
} }
c.descriptionCache.Put(sd)
} }
return c.execParams(ctx, sd, arguments) return c.execParams(ctx, sd, arguments)

6
conn_test.go
View File

@ -482,9 +482,10 @@ func TestPrepareBadSQLFailure(t *testing.T) {
func TestPrepareIdempotency(t *testing.T) { func TestPrepareIdempotency(t *testing.T) {
t.Parallel() t.Parallel()
conn := mustConnectString(t, os.Getenv("PGX_TEST_DATABASE")) ctx, cancel := context.WithTimeout(context.Background(), 120*time.Second)
defer closeConn(t, conn) defer cancel()
pgxtest.RunWithQueryExecModes(ctx, t, defaultConnTestRunner, nil, func(ctx context.Context, t testing.TB, conn *pgx.Conn) {
for i := 0; i < 2; i++ { for i := 0; i < 2; i++ {
_, err := conn.Prepare(context.Background(), "test", "select 42::integer") _, err := conn.Prepare(context.Background(), "test", "select 42::integer")
if err != nil { if err != nil {
@ -507,6 +508,7 @@ func TestPrepareIdempotency(t *testing.T) {
t.Fatalf("Prepare statement with same name but different SQL should have failed but it didn't") t.Fatalf("Prepare statement with same name but different SQL should have failed but it didn't")
return return
} }
})
} }
func TestPrepareStatementCacheModes(t *testing.T) { func TestPrepareStatementCacheModes(t *testing.T) {