GOMODULES
/
pgx
mirror of https://github.com/jackc/pgx.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Document new ResultReader.Values behavior

pull/1281/head
Jack Christensen 2022-07-11 21:15:37 -05:00
parent f0cd9cb867
commit 3dc9d17757
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.md
View File

@ -10,6 +10,8 @@ release work due to releasing multiple packages, and less clear changelogs.
`CommandTag` is now an opaque type instead of directly exposing an underlying `[]byte`. `CommandTag` is now an opaque type instead of directly exposing an underlying `[]byte`.
The return value `ResultReader.Values()` is no longer safe to retain a reference to after a subsequent call to `NextRow()` or `Close()`.
`Trace()` method adds low level message tracing similar to the `PQtrace` function in `libpq`. `Trace()` method adds low level message tracing similar to the `PQtrace` function in `libpq`.
pgconn now uses non-blocking IO. This is a significant internal restructuring, but it should not cause any visible changes on its own. However, it is important in implementing other new features. pgconn now uses non-blocking IO. This is a significant internal restructuring, but it should not cause any visible changes on its own. However, it is important in implementing other new features.

3
pgconn/pgconn.go
View File

@ -1358,8 +1358,7 @@ func (rr *ResultReader) FieldDescriptions() []pgproto3.FieldDescription {
} }
// Values returns the current row data. NextRow must have been previously been called. The returned [][]byte is only // Values returns the current row data. NextRow must have been previously been called. The returned [][]byte is only
// valid until the next NextRow call or the ResultReader is closed. However, the underlying byte data is safe to // valid until the next NextRow call or the ResultReader is closed.
// retain a reference to and mutate.
func (rr *ResultReader) Values() [][]byte { func (rr *ResultReader) Values() [][]byte {
return rr.rowValues return rr.rowValues
} }