From 33d4fa0fa69a02069a02c96b329859ba4bfa344c Mon Sep 17 00:00:00 2001 From: Nicola Murino Date: Sat, 27 May 2023 22:56:59 +0200 Subject: [PATCH] TLS with Fake Non-blocking IO test is expected to fail on Windows --- internal/nbconn/nbconn_test.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/internal/nbconn/nbconn_test.go b/internal/nbconn/nbconn_test.go index 92bff9c9..4fb2282b 100644 --- a/internal/nbconn/nbconn_test.go +++ b/internal/nbconn/nbconn_test.go @@ -4,6 +4,7 @@ import ( "crypto/tls" "io" "net" + "runtime" "strings" "testing" "time" @@ -299,8 +300,12 @@ func TestInternalNonBlockingWrite(t *testing.T) { err = conn.Close() require.NoError(t, err) - - require.NoError(t, <-errChan) + if runtime.GOOS == "windows" && t.Name() == "TestInternalNonBlockingWrite/TLS_over_TCP_with_Fake_Non-blocking_IO" { + // this test is expected to fail on Windows see https://github.com/golang/go/issues/58764 + require.Error(t, <-errChan) + } else { + require.NoError(t, <-errChan) + } }) }