From 2b63da6f126e8c8d5d2bb1e2080a9ee43426f141 Mon Sep 17 00:00:00 2001 From: Jack Christensen Date: Sat, 27 Feb 2021 10:03:58 -0600 Subject: [PATCH] Skip backend PID dependent tests on CockroachDB --- pgxpool/pool_test.go | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/pgxpool/pool_test.go b/pgxpool/pool_test.go index 4e19ee35..965f342f 100644 --- a/pgxpool/pool_test.go +++ b/pgxpool/pool_test.go @@ -228,6 +228,20 @@ func TestPoolBeforeAcquire(t *testing.T) { func TestPoolAfterRelease(t *testing.T) { t.Parallel() + func() { + pool, err := pgxpool.Connect(context.Background(), os.Getenv("PGX_TEST_DATABASE")) + require.NoError(t, err) + defer pool.Close() + + err = pool.AcquireFunc(context.Background(), func(conn *pgxpool.Conn) error { + if conn.Conn().PgConn().ParameterStatus("crdb_version") != "" { + t.Skip("Server does not support backend PID") + } + return nil + }) + require.NoError(t, err) + }() + config, err := pgxpool.ParseConfig(os.Getenv("PGX_TEST_DATABASE")) require.NoError(t, err) @@ -533,6 +547,14 @@ func TestConnReleaseClosesConnInFailedTransaction(t *testing.T) { require.NoError(t, err) defer pool.Close() + err = pool.AcquireFunc(ctx, func(conn *pgxpool.Conn) error { + if conn.Conn().PgConn().ParameterStatus("crdb_version") != "" { + t.Skip("Server does not support backend PID") + } + return nil + }) + require.NoError(t, err) + c, err := pool.Acquire(ctx) require.NoError(t, err) @@ -571,6 +593,14 @@ func TestConnReleaseClosesConnInTransaction(t *testing.T) { require.NoError(t, err) defer pool.Close() + err = pool.AcquireFunc(ctx, func(conn *pgxpool.Conn) error { + if conn.Conn().PgConn().ParameterStatus("crdb_version") != "" { + t.Skip("Server does not support backend PID") + } + return nil + }) + require.NoError(t, err) + c, err := pool.Acquire(ctx) require.NoError(t, err)