GOMODULES
/
pgx
mirror of https://github.com/jackc/pgx.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix misleading error message

pull/29/head
Jack Christensen 2014-08-08 10:31:47 -05:00
parent fb55203324
commit 2a04433355
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
conn.go
View File

@ -530,7 +530,7 @@ func (c *Conn) sendPreparedQuery(ps *PreparedStatement, arguments ...interface{}
case VarcharArrayOid:
err = encodeTextArray(wbuf, arguments[i], VarcharOid)
default:
return SerializationError(fmt.Sprintf("%T is not a core type and it does not implement Encoder", arg))
return SerializationError(fmt.Sprintf("Cannot encode %T into oid %v - %T must implement Encoder or be converted to a string", arg, oid, arg))
}
}
if err != nil {

2
query_test.go
View File

@ -437,6 +437,7 @@ func TestQueryRowErrors(t *testing.T) {
type allTypes struct {
i16 int16
s string
}
var actual, zero allTypes
@ -451,6 +452,7 @@ func TestQueryRowErrors(t *testing.T) {
{"select $1::badtype", []interface{}{"Jack"}, []interface{}{&actual.i16}, `type "badtype" does not exist`},
{"SYNTAX ERROR", []interface{}{}, []interface{}{&actual.i16}, "SQLSTATE 42601"},
{"select $1::text", []interface{}{"Jack"}, []interface{}{&actual.i16}, "Expected type oid 21 but received type oid 25"},
{"select $1::int8range", []interface{}{int(705)}, []interface{}{&actual.s}, "Cannot encode int into oid 3926 - int must implement Encoder or be converted to a string"},
}
for i, tt := range tests {