GOMODULES
/
pgx
mirror of https://github.com/jackc/pgx.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove skipped test for scan binary to string 

Receiving a binary value and encoding it back into text seems to be an
anti-pattern to may. Don't want to silently enable this. May be able to
reverse course later if necessary.
pull/1185/head
Jack Christensen 2022-03-22 19:25:41 -05:00
parent 0cd7c757c3
commit 29bec2b97e
1 changed files with 0 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
values_test.go
View File

@ -242,33 +242,6 @@ func mustParseCIDR(t *testing.T, s string) *net.IPNet {
return ipnet
}
func TestStringToNotTextTypeTranscode(t *testing.T) {
t.Skip("TODO - unskip later in v5") // Should this even be a thing... i.e. anything is scanable to a string to a string
t.Parallel()
testWithAllQueryExecModes(t, func(t *testing.T, conn *pgx.Conn) {
input := "01086ee0-4963-4e35-9116-30c173a8d0bd"
var output string
err := conn.QueryRow(context.Background(), "select $1::uuid", input).Scan(&output)
if err != nil {
t.Fatal(err)
}
if input != output {
t.Errorf("uuid: Did not transcode string successfully: %s is not %s", input, output)
}
err = conn.QueryRow(context.Background(), "select $1::uuid", &input).Scan(&output)
if err != nil {
t.Fatal(err)
}
if input != output {
t.Errorf("uuid: Did not transcode pointer to string successfully: %s is not %s", input, output)
}
})
}
func TestInetCIDRTranscodeIPNet(t *testing.T) {
t.Parallel()