From 26eda0f86d2b9e357be5e66ec1b4421660291d0c Mon Sep 17 00:00:00 2001 From: Jack Christensen Date: Sat, 25 Jun 2022 16:55:09 -0500 Subject: [PATCH] Check for ENV conn string and skip test if missing --- pgconn/pgconn_test.go | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/pgconn/pgconn_test.go b/pgconn/pgconn_test.go index f517f268..b47f17d6 100644 --- a/pgconn/pgconn_test.go +++ b/pgconn/pgconn_test.go @@ -2062,7 +2062,14 @@ func TestConnLargeResponseWhileWritingDoesNotDeadlock(t *testing.T) { func TestConnCheckConn(t *testing.T) { t.Parallel() - c1, err := pgconn.Connect(context.Background(), os.Getenv("PGX_TEST_TCP_CONN_STRING")) + // Intentionally using TCP connection for more predictable close behavior. (Not sure if Unix domain sockets would behave subtlely different.) + + connString := os.Getenv(os.Getenv("PGX_TEST_TCP_CONN_STRING")) + if connString == "" { + t.Skipf("Skipping due to missing environment variable %v", "PGX_TEST_TCP_CONN_STRING") + } + + c1, err := pgconn.Connect(context.Background(), connString) require.NoError(t, err) defer c1.Close(context.Background()) @@ -2073,7 +2080,7 @@ func TestConnCheckConn(t *testing.T) { err = c1.CheckConn() require.NoError(t, err) - c2, err := pgconn.Connect(context.Background(), os.Getenv("PGX_TEST_TCP_CONN_STRING")) + c2, err := pgconn.Connect(context.Background(), connString) require.NoError(t, err) defer c2.Close(context.Background())